Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4161)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java

Issue 2632693002: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… (Closed)
Patch Set: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
index 71086e8db23c387e45b02c052dc02970366ff1bb..498cceb34a82484bae1bf93faeabe76d0a8ad731 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/InstallerDelegate.java
@@ -4,17 +4,13 @@
package org.chromium.chrome.browser.banners;
-import android.content.pm.PackageInfo;
import android.content.pm.PackageManager;
import android.os.Handler;
import android.os.Looper;
import android.os.SystemClock;
-import android.text.TextUtils;
import org.chromium.base.VisibleForTesting;
-import java.util.List;
-
/**
* Monitors the PackageManager to see when an app has been installed.
*/
@@ -107,11 +103,12 @@ public class InstallerDelegate implements Runnable {
* @return True if the PackageManager reports that the app is installed, false otherwise.
*/
public static boolean isInstalled(PackageManager packageManager, String packageName) {
- List<PackageInfo> packs = packageManager.getInstalledPackages(0);
- for (int i = 0; i < packs.size(); i++) {
- if (TextUtils.equals(packs.get(i).packageName, packageName)) return true;
+ try {
+ packageManager.getPackageInfo(packageName, 0);
+ } catch (PackageManager.NameNotFoundException e) {
+ return false;
}
- return false;
+ return true;
}
/**
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698