MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag.

chrome/browser/ui/BUILD.gn

Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index de0ea0ae096e112a7b7ab7c63096246c73581a83..467dada0b1f6c9214d85ef253741b1492f91afc0 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -1544,27 +1544,32 @@ split_static_library("ui") {
         "views/apps/app_info_dialog/arc_app_info_links_panel.cc",
         "views/apps/app_info_dialog/arc_app_info_links_panel.h",
       ]
-    } else if (!is_mac || mac_views_browser) {
+    } else {
       sources += [
         "external_protocol_dialog_delegate.cc",
         "external_protocol_dialog_delegate.h",
         "views/external_protocol_dialog.cc",

[tapted, 2017/01/17 21:17:13]

Can external_protocol_dialog_browsertest be switched on in chrome/test/BUILD.gn?

[karandeepb, 2017/01/24 03:23:32]

Done.

         "views/external_protocol_dialog.h",
-        "views/frame/opaque_browser_frame_view.cc",
-        "views/frame/opaque_browser_frame_view.h",
-        "views/frame/opaque_browser_frame_view_layout.cc",
-        "views/frame/opaque_browser_frame_view_layout.h",
-        "views/frame/opaque_browser_frame_view_layout_delegate.h",
-        "views/frame/opaque_browser_frame_view_linux.cc",
-        "views/frame/opaque_browser_frame_view_linux.h",
-        "views/frame/opaque_browser_frame_view_platform_specific.cc",
-        "views/frame/opaque_browser_frame_view_platform_specific.h",
-        "views/profiles/profile_chooser_view.cc",
-        "views/profiles/profile_chooser_view.h",
-        "views/screen_capture_notification_ui_views.cc",
-        "views/sync/one_click_signin_dialog_view.cc",
-        "views/sync/one_click_signin_dialog_view.h",
       ]
+
+      if (!is_mac || mac_views_browser) {

[tapted, 2017/01/17 21:17:13]

nesting this also with toolkit_views might be a bit much (and, e.g., there are
two levels checking platform - is_chromeos, is_mac). Perhaps

if (!is_chromeos && (!is_mac || mac_views_browser)) ?

[karandeepb, 2017/01/24 03:23:32]

Done.

+        sources += [
+          "views/frame/opaque_browser_frame_view.cc",
+          "views/frame/opaque_browser_frame_view.h",
+          "views/frame/opaque_browser_frame_view_layout.cc",
+          "views/frame/opaque_browser_frame_view_layout.h",
+          "views/frame/opaque_browser_frame_view_layout_delegate.h",
+          "views/frame/opaque_browser_frame_view_linux.cc",
+          "views/frame/opaque_browser_frame_view_linux.h",
+          "views/frame/opaque_browser_frame_view_platform_specific.cc",
+          "views/frame/opaque_browser_frame_view_platform_specific.h",
+          "views/profiles/profile_chooser_view.cc",
+          "views/profiles/profile_chooser_view.h",
+          "views/screen_capture_notification_ui_views.cc",
+          "views/sync/one_click_signin_dialog_view.cc",
+          "views/sync/one_click_signin_dialog_view.h",
+        ]
+      }
     }
 
     # These files do Gtk+-based theming, but Gtk+ is not available on
@@ -2680,7 +2685,7 @@ split_static_library("ui") {
         "cocoa/extensions/windowed_install_dialog_controller.h",
         "cocoa/extensions/windowed_install_dialog_controller.mm",
         "cocoa/external_protocol_dialog.h",
-        "cocoa/external_protocol_dialog.mm",
+        "cocoa/external_protocol_dialog_cocoa.mm",
         "cocoa/fast_resize_view.h",
         "cocoa/fast_resize_view.mm",
         "cocoa/find_bar/find_bar_bridge.h",