Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: chrome/browser/chromeos/external_protocol_dialog.cc

Issue 2632653002: MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag. (Closed)
Patch Set: Fix chromeos Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/external_protocol_dialog.cc
diff --git a/chrome/browser/chromeos/external_protocol_dialog.cc b/chrome/browser/chromeos/external_protocol_dialog.cc
index 383e4d804d14a25071c899d08e63f98198d943ef..bbe0849acda8045b55115d97fe8ca439771d9a1b 100644
--- a/chrome/browser/chromeos/external_protocol_dialog.cc
+++ b/chrome/browser/chromeos/external_protocol_dialog.cc
@@ -25,16 +25,13 @@ const int kMessageWidth = 400;
} // namespace
-///////////////////////////////////////////////////////////////////////////////
-// ExternalProtocolHandler
-
-// static
-void ExternalProtocolHandler::RunExternalProtocolDialog(
- const GURL& url,
- int render_process_host_id,
- int routing_id,
- ui::PageTransition page_transition,
- bool has_user_gesture) {
+namespace chrome {
+
+void RunExternalProtocolDialogViews(const GURL& url,
karandeepb 2017/01/16 11:13:10 I am assuming it's fine to name the chromeos versi
tapted 2017/01/17 21:17:13 seems reasonable.. but I think we can avoid this c
karandeepb 2017/01/24 03:23:32 Done.
+ int render_process_host_id,
+ int routing_id,
+ ui::PageTransition page_transition,
+ bool has_user_gesture) {
// First, check if ARC version of the dialog is available and run ARC version
// when possible.
if (arc::RunArcExternalProtocolDialog(url, render_process_host_id, routing_id,
@@ -46,6 +43,8 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(
new ExternalProtocolDialog(web_contents, url);
}
+} // namespace chrome
+
///////////////////////////////////////////////////////////////////////////////
// ExternalProtocolDialog
« no previous file with comments | « no previous file | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698