MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag.

chrome/browser/ui/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/split_static_library.gni")
 import("//chrome/common/features.gni")
@@ skipping 1526 matching lines @@
 
     if (enable_extensions) {
       deps += [ "//extensions/components/native_app_window" ]
     }
 
     if (is_chromeos) {
       sources += [
         "views/apps/app_info_dialog/arc_app_info_links_panel.cc",
         "views/apps/app_info_dialog/arc_app_info_links_panel.h",
       ]
-    } else if (!is_mac || mac_views_browser) {
+    } else {
       sources += [
         "external_protocol_dialog_delegate.cc",
         "external_protocol_dialog_delegate.h",
         "views/external_protocol_dialog.cc",

[tapted, 2017/01/17 21:17:13]

Can external_protocol_dialog_browsertest be switched on in chrome/test/BUILD.gn?

[karandeepb, 2017/01/24 03:23:32]

Done.

         "views/external_protocol_dialog.h",
-        "views/frame/opaque_browser_frame_view.cc",
-        "views/frame/opaque_browser_frame_view.h",
-        "views/frame/opaque_browser_frame_view_layout.cc",
-        "views/frame/opaque_browser_frame_view_layout.h",
-        "views/frame/opaque_browser_frame_view_layout_delegate.h",
-        "views/frame/opaque_browser_frame_view_linux.cc",
-        "views/frame/opaque_browser_frame_view_linux.h",
-        "views/frame/opaque_browser_frame_view_platform_specific.cc",
-        "views/frame/opaque_browser_frame_view_platform_specific.h",
-        "views/profiles/profile_chooser_view.cc",
-        "views/profiles/profile_chooser_view.h",
-        "views/screen_capture_notification_ui_views.cc",
-        "views/sync/one_click_signin_dialog_view.cc",
-        "views/sync/one_click_signin_dialog_view.h",
       ]
+
+      if (!is_mac || mac_views_browser) {

[tapted, 2017/01/17 21:17:13]

nesting this also with toolkit_views might be a bit much (and, e.g., there are
two levels checking platform - is_chromeos, is_mac). Perhaps

if (!is_chromeos && (!is_mac || mac_views_browser)) ?

[karandeepb, 2017/01/24 03:23:32]

Done.

+        sources += [
+          "views/frame/opaque_browser_frame_view.cc",
+          "views/frame/opaque_browser_frame_view.h",
+          "views/frame/opaque_browser_frame_view_layout.cc",
+          "views/frame/opaque_browser_frame_view_layout.h",
+          "views/frame/opaque_browser_frame_view_layout_delegate.h",
+          "views/frame/opaque_browser_frame_view_linux.cc",
+          "views/frame/opaque_browser_frame_view_linux.h",
+          "views/frame/opaque_browser_frame_view_platform_specific.cc",
+          "views/frame/opaque_browser_frame_view_platform_specific.h",
+          "views/profiles/profile_chooser_view.cc",
+          "views/profiles/profile_chooser_view.h",
+          "views/screen_capture_notification_ui_views.cc",
+          "views/sync/one_click_signin_dialog_view.cc",
+          "views/sync/one_click_signin_dialog_view.h",
+        ]
+      }
     }
 
     # These files do Gtk+-based theming, but Gtk+ is not available on
     # Ozone builds, or on common environments where Ozone will be used.
     #
     # TODO(tonikitoo): It seems sensible to make it possible to opt-in
     # the use of these files in case Gtk is available with its Wayland.
     if (use_aura && !use_ozone && is_desktop_linux) {
       sources += [
         "views/chrome_browser_main_extra_parts_views_linux.cc",
@@ skipping 1095 matching lines @@
         "cocoa/extensions/extension_view_mac.mm",
         "cocoa/extensions/media_galleries_dialog_cocoa.h",
         "cocoa/extensions/media_galleries_dialog_cocoa.mm",
         "cocoa/extensions/media_gallery_list_entry_view.h",
         "cocoa/extensions/media_gallery_list_entry_view.mm",
         "cocoa/extensions/toolbar_actions_bar_bubble_mac.h",
         "cocoa/extensions/toolbar_actions_bar_bubble_mac.mm",
         "cocoa/extensions/windowed_install_dialog_controller.h",
         "cocoa/extensions/windowed_install_dialog_controller.mm",
         "cocoa/external_protocol_dialog.h",
-        "cocoa/external_protocol_dialog.mm",
+        "cocoa/external_protocol_dialog_cocoa.mm",
         "cocoa/fast_resize_view.h",
         "cocoa/fast_resize_view.mm",
         "cocoa/find_bar/find_bar_bridge.h",
         "cocoa/find_bar/find_bar_bridge.mm",
         "cocoa/find_bar/find_bar_cocoa_controller.h",
         "cocoa/find_bar/find_bar_cocoa_controller.mm",
         "cocoa/find_bar/find_bar_text_field.h",
         "cocoa/find_bar/find_bar_text_field.mm",
         "cocoa/find_bar/find_bar_text_field_cell.h",
         "cocoa/find_bar/find_bar_text_field_cell.mm",
@@ skipping 794 matching lines @@
       "test/test_confirm_bubble_model.cc",
       "test/test_confirm_bubble_model.h",
     ]
     deps += [ "//chrome/test:test_support_ui" ]
   }
 
   if (enable_extensions) {
     deps += [ "//extensions/browser" ]
   }
 }