MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag.

chrome/browser/chromeos/external_protocol_dialog.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/external_protocol_dialog.h"
 
 #include "chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.h"
 #include "chrome/browser/external_protocol/external_protocol_handler.h"
 #include "chrome/browser/tab_contents/tab_util.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/strings/grit/components_strings.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/text_elider.h"
 #include "ui/views/controls/message_box_view.h"
 #include "ui/views/widget/widget.h"
 #include "url/gurl.h"
 
 using content::WebContents;
 
 namespace {
 
 const int kMessageWidth = 400;
 
 }  // namespace
 
-///////////////////////////////////////////////////////////////////////////////
-// ExternalProtocolHandler
+namespace chrome {
 
-// static
-void ExternalProtocolHandler::RunExternalProtocolDialog(
-    const GURL& url,
-    int render_process_host_id,
-    int routing_id,
-    ui::PageTransition page_transition,
-    bool has_user_gesture) {
+void RunExternalProtocolDialogViews(const GURL& url,

[karandeepb, 2017/01/16 11:13:10]

I am assuming it's fine to name the chromeos version with the suffix "Views".

[tapted, 2017/01/17 21:17:13]

seems reasonable.. but I think we can avoid this change with
BUILDFLAG(MAC_VIEWS_BROWSER) - see below

[karandeepb, 2017/01/24 03:23:32]

Done.

+                                    int render_process_host_id,
+                                    int routing_id,
+                                    ui::PageTransition page_transition,
+                                    bool has_user_gesture) {
   // First, check if ARC version of the dialog is available and run ARC version
   // when possible.
   if (arc::RunArcExternalProtocolDialog(url, render_process_host_id, routing_id,
                                         page_transition, has_user_gesture)) {
     return;
   }
   WebContents* web_contents = tab_util::GetWebContentsByID(
       render_process_host_id, routing_id);
   new ExternalProtocolDialog(web_contents, url);
 }
 
+}  // namespace chrome
+
 ///////////////////////////////////////////////////////////////////////////////
 // ExternalProtocolDialog
 
 ExternalProtocolDialog::~ExternalProtocolDialog() {
 }
 
 //////////////////////////////////////////////////////////////////////////////
 // ExternalProtocolDialog, views::DialogDelegate implementation:
 
 int ExternalProtocolDialog::GetDialogButtons() const {
@@ skipping 46 matching lines @@
 
   gfx::NativeWindow parent_window;
   if (web_contents) {
     parent_window = web_contents->GetTopLevelNativeWindow();
   } else {
     // Dialog is top level if we don't have a web_contents associated with us.
     parent_window = NULL;
   }
   views::DialogDelegate::CreateDialogWidget(this, NULL, parent_window)->Show();
 }