Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2632643003: Revert of Remove obsolete PauseableHttpProtocolHandler class. (Closed)

Created:
3 years, 11 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 11 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove obsolete PauseableHttpProtocolHandler class. (patchset #1 id:1 of https://codereview.chromium.org/2627973005/ ) Reason for revert: Breaks CroNet Original issue's description: > Remove obsolete PauseableHttpProtocolHandler class. > > This class is never referenced apart from declaration/definition > and thus can be removed from the codebase. > > BUG=585700 > > Review-Url: https://codereview.chromium.org/2627973005 > Cr-Commit-Position: refs/heads/master@{#443578} > Committed: https://chromium.googlesource.com/chromium/src/+/5688a4a82f90d9c27ab3e39d0dd682ca31f5876a TBR=sdefresne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585700 Review-Url: https://codereview.chromium.org/2632643003 Cr-Commit-Position: refs/heads/master@{#443629} Committed: https://chromium.googlesource.com/chromium/src/+/9d4f71cb85e6a4975e40384916b5165022528e13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M ios/net/crn_http_protocol_handler.h View 1 chunk +9 lines, -0 lines 0 comments Download
M ios/net/crn_http_protocol_handler.mm View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Eugene But (OOO till 7-30)
Created Revert of Remove obsolete PauseableHttpProtocolHandler class.
3 years, 11 months ago (2017-01-13 18:54:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632643003/1
3 years, 11 months ago (2017-01-13 18:55:07 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 18:57:00 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d4f71cb85e6a4975e40384916b5...

Powered by Google App Engine
This is Rietveld 408576698