Fix crash when set VR mode to false after VrShell is destroyed

Fix crash when set VR mode to false after VrShell is destroyed


BUG=680216
Review-Url: https://codereview.chromium.org/2632493004
Cr-Commit-Position: refs/heads/master@{#443653}
Committed: https://chromium.googlesource.com/chromium/src/+/66b3577ead1992c749bd9af002413e6e408c5bd3

[bshe, 2017-01-13 16:56:43]

bshe@chromium.org changed reviewers:
+ agrieve@chromium.org, mthiesse@chromium.org

[bshe, 2017-01-13 16:56:43]

+mthiesse for vr_shell related code. There was a crash happening if we exit VR
through mDaydreamApi.exitFromVr, which will trigger onExitVREvent function
asynchronously. And at that time, mVrShell may already destroyed. In this CL, I
moved setVrMode to VrClassesWrapper which won't be destroyed.

+agrieve for a trivial change in java_sources.jni

Thanks!

[agrieve, 2017-01-13 17:55:18]

On 2017/01/13 16:56:43, bshe wrote:
> +mthiesse for vr_shell related code. There was a crash happening if we exit VR
> through mDaydreamApi.exitFromVr, which will trigger onExitVREvent function
> asynchronously. And at that time, mVrShell may already destroyed. In this CL,
I
> moved setVrMode to VrClassesWrapper which won't be destroyed.
> 
> +agrieve for a trivial change in java_sources.jni
> 
> Thanks!

sources lgtm

[mthiesse, 2017-01-13 17:59:55]

lgtm

[bshe, 2017-01-13 19:16:30]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2017-01-13 19:17:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 20:40:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484334990030490, "parent_rev":
"7628154b26186300379aa54027d019dd186f657d", "commit_rev":
"66b3577ead1992c749bd9af002413e6e408c5bd3"}

[commit-bot: I haz the power, 2017-01-13 20:41:10]

Description was changed from

==========
Fix crash when set VR mode to false after VrShell is destroyed


BUG=680216
==========

to

==========
Fix crash when set VR mode to false after VrShell is destroyed


BUG=680216

Review-Url: https://codereview.chromium.org/2632493004
Cr-Commit-Position: refs/heads/master@{#443653}
Committed:
https://chromium.googlesource.com/chromium/src/+/66b3577ead1992c749bd9af00241...
==========

[commit-bot: I haz the power, 2017-01-13 20:41:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66b3577ead1992c749bd9af00241...