Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java

Issue 2632493004: Fix crash when set VR mode to false after VrShell is destroyed (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
similarity index 83%
rename from chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java
rename to chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
index 067749b5ba56c11a87ff12b8b1a22f3270a552b9..5c2334668157e0de1c6988ce1194a461481cfda7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java
@@ -7,6 +7,8 @@ package org.chromium.chrome.browser.vr_shell;
import android.app.Activity;
import android.os.StrictMode;
+import com.google.vr.ndk.base.AndroidCompat;
+
import org.chromium.base.Log;
import org.chromium.base.annotations.UsedByReflection;
@@ -15,12 +17,12 @@ import org.chromium.base.annotations.UsedByReflection;
* flag as this class. So no reflection is necessary when create them.
*/
@UsedByReflection("VrShellDelegate.java")
-public class VrClassesBuilderImpl implements VrClassesBuilder {
- private static final String TAG = "VrClassesBuilderImpl";
+public class VrClassesWrapperImpl implements VrClassesWrapper {
+ private static final String TAG = "VrClassesWrapperImpl";
private final Activity mActivity;
@UsedByReflection("VrShellDelegate.java")
- public VrClassesBuilderImpl(Activity activity) {
+ public VrClassesWrapperImpl(Activity activity) {
mActivity = activity;
}
@@ -59,4 +61,9 @@ public class VrClassesBuilderImpl implements VrClassesBuilder {
public VrCoreVersionChecker createVrCoreVersionChecker() {
return new VrCoreVersionCheckerImpl();
}
+
+ @Override
+ public void setVrModeEnabled(boolean enabled) {
+ AndroidCompat.setVrModeEnabled(mActivity, enabled);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698