[Android History] Styling changes

[Android History] Styling changes

 * Changes background color to grey.
 * Remove trash can buttons and disables clear browsing data
   when selection is enabled.
 * Hides/shows toolbar shadow according to specification.
 * Fixes bug with search icon visibility.
 * Add some more tests.

BUG=654071
Review-Url: https://codereview.chromium.org/2632493003
Cr-Commit-Position: refs/heads/master@{#443723}
Committed: https://chromium.googlesource.com/chromium/src/+/949dd87adb3934ef224e7c46ae823f1dab6c25bf

[Theresa, 2017-01-12 19:29:49]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 19:30:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-01-12 19:33:28]

Description was changed from

==========
[Android History] Work on styling changes

 * Changes background color to grey.
 * Remove trash can buttons and disables clear browsing data
   when selection is enabled.
 * Hides/shows toolbar shadow according to specification.
 * Fixes bug with search icon visibility.
 * Add some more tests.

BUG=654071
==========

to

==========
[Android History] Styling changes

 * Changes background color to grey.
 * Remove trash can buttons and disables clear browsing data
   when selection is enabled.
 * Hides/shows toolbar shadow according to specification.
 * Fixes bug with search icon visibility.
 * Add some more tests.

BUG=654071
==========

[Theresa, 2017-01-12 19:36:05]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2017-01-12 19:36:05]

ptal

[commit-bot: I haz the power, 2017-01-12 20:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 20:06:56]

Dry run: This issue passed the CQ dry run.

[gone, 2017-01-13 18:27:48]

lgtm

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java
(right):

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java:50:
private Button mCbdButton;
Expand Cbd?

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
(right):

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java:135:
mRemoveButton.setClickable(enabled);
Would setting the button's visibility to INVISIBLE/VISIBLE accomplish the same
goal?

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java
(right):

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java:150:
setBackgroundColor(Color.WHITE);
Does this have to be undone in the above part of the conditional?

[Theresa, 2017-01-13 19:40:11]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2017-01-13 19:40:28]

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java
(right):

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java:50:
private Button mCbdButton;
On 2017/01/13 18:27:47, dfalcantara (load balance plz) wrote:
> Expand Cbd?

Done.

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
(right):

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java:135:
mRemoveButton.setClickable(enabled);
On 2017/01/13 18:27:47, dfalcantara (load balance plz) wrote:
> Would setting the button's visibility to INVISIBLE/VISIBLE accomplish the same
> goal?

Yes, done.

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java
(right):

https://codereview.chromium.org/2632493003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerToolbar.java:150:
setBackgroundColor(Color.WHITE);
On 2017/01/13 18:27:48, dfalcantara (load balance plz) wrote:
> Does this have to be undone in the above part of the conditional?

Done. It was working, but as discussed offline it's better to be explicit about
it so I'm setting the background in hideSearchView() and showSearchView().

[commit-bot: I haz the power, 2017-01-13 19:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-01-13 19:42:11]

lgtm

[commit-bot: I haz the power, 2017-01-13 19:45:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 19:45:02]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Theresa, 2017-01-13 20:14:28]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 20:15:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2017-01-13 20:15:34]

The CQ bit was unchecked by twellington@chromium.org

[Theresa, 2017-01-13 20:15:35]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-01-13 20:15:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2632493003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-13 20:16:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 21:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:57:15]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Theresa, 2017-01-13 22:30:21]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 22:30:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:23:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:23:43]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-01-13 23:23:58]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-01-13 23:23:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2632493003/#ps60001
(title: "Fix remove button visibility for supervised users")

[commit-bot: I haz the power, 2017-01-13 23:24:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:30:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484349838987110,
"parent_rev": "4f967e37373dede46998532fbcbd268d1d32be42", "commit_rev":
"949dd87adb3934ef224e7c46ae823f1dab6c25bf"}

[commit-bot: I haz the power, 2017-01-13 23:31:23]

Description was changed from

==========
[Android History] Styling changes

 * Changes background color to grey.
 * Remove trash can buttons and disables clear browsing data
   when selection is enabled.
 * Hides/shows toolbar shadow according to specification.
 * Fixes bug with search icon visibility.
 * Add some more tests.

BUG=654071
==========

to

==========
[Android History] Styling changes

 * Changes background color to grey.
 * Remove trash can buttons and disables clear browsing data
   when selection is enabled.
 * Hides/shows toolbar shadow according to specification.
 * Fixes bug with search icon visibility.
 * Add some more tests.

BUG=654071

Review-Url: https://codereview.chromium.org/2632493003
Cr-Commit-Position: refs/heads/master@{#443723}
Committed:
https://chromium.googlesource.com/chromium/src/+/949dd87adb3934ef224e7c46ae82...
==========

[commit-bot: I haz the power, 2017-01-13 23:31:24]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/949dd87adb3934ef224e7c46ae82...