Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java

Issue 2632493003: [Android History] Styling changes (Closed)
Patch Set: Fix remove button visibility for supervised users Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
index 3320536863fa198234163bfae273868d9a2ce04b..570d86c8d464f480a33e0fb42132787e3afbe406 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListLayout.java
@@ -79,14 +79,6 @@ public class SelectableListLayout<E> extends RelativeLayout {
mToolbarStub = (ViewStub) findViewById(R.id.action_bar_stub);
- FadingShadowView shadow = (FadingShadowView) findViewById(R.id.shadow);
- if (DeviceFormFactor.isLargeTablet(getContext())) {
- shadow.setVisibility(View.GONE);
- } else {
- shadow.init(ApiCompatibilityUtils.getColor(getResources(),
- R.color.toolbar_shadow_color), FadingShadow.POSITION_TOP);
- }
-
setFocusable(true);
setFocusableInTouchMode(true);
}
@@ -121,18 +113,33 @@ public class SelectableListLayout<E> extends RelativeLayout {
* established.
* @param selectedGroupResId The resource id of the menu item to show when a selection is
* established.
+ * @param normalBackgroundColorResId The resource id of the color to use as the background color
+ * when selection is not enabled. If null the default appbar
+ * background color will be used.
+ * @param hideShadowOnLargeTablets Whether the toolbar shadow should be hidden on large tablets.
* @param listener The OnMenuItemClickListener to set on the toolbar.
* @return The initialized SelectionToolbar.
*/
public SelectionToolbar<E> initializeToolbar(int toolbarLayoutId,
SelectionDelegate<E> delegate, int titleResId, @Nullable DrawerLayout drawerLayout,
- int normalGroupResId, int selectedGroupResId, OnMenuItemClickListener listener) {
+ int normalGroupResId, int selectedGroupResId,
+ @Nullable Integer normalBackgroundColorResId, boolean hideShadowOnLargeTablets,
+ OnMenuItemClickListener listener) {
+
+ FadingShadowView shadow = (FadingShadowView) findViewById(R.id.shadow);
+ if (hideShadowOnLargeTablets && DeviceFormFactor.isLargeTablet(getContext())) {
+ shadow.setVisibility(View.GONE);
+ } else {
+ shadow.init(ApiCompatibilityUtils.getColor(getResources(),
+ R.color.toolbar_shadow_color), FadingShadow.POSITION_TOP);
+ }
+
mToolbarStub.setLayoutResource(toolbarLayoutId);
@SuppressWarnings("unchecked")
SelectionToolbar<E> toolbar = (SelectionToolbar<E>) mToolbarStub.inflate();
mToolbar = toolbar;
mToolbar.initialize(delegate, titleResId, drawerLayout, normalGroupResId,
- selectedGroupResId);
+ selectedGroupResId, normalBackgroundColorResId);
mToolbar.setOnMenuItemClickListener(listener);
return mToolbar;
}

Powered by Google App Engine
This is Rietveld 408576698