cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG=679837
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2632313002
Cr-Commit-Position: refs/heads/master@{#444060}
Committed: https://chromium.googlesource.com/chromium/src/+/695875dd4c75b268f423628eae300a700e156751

[ajuma, 2017-01-17 00:20:20]

Description was changed from

==========
cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG=679837
==========

to

==========
cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG=679837
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-01-17 00:22:33]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 00:22:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2017-01-17 00:39:51]

Patchset #1 (id:1) has been deleted

[ajuma, 2017-01-17 00:40:57]

The CQ bit was checked by ajuma@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 00:41:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 01:33:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 01:33:33]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-01-17 14:16:38]

Description was changed from

==========
cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG=679837
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG=679837
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ajuma, 2017-01-17 14:16:38]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[weiliangc, 2017-01-17 15:42:16]

LGTM

[ajuma, 2017-01-17 15:47:15]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2017-01-17 15:47:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 15:51:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484668035468170,
"parent_rev": "c7b9fad65713c1a91b5e277b2caace74694c15d4", "commit_rev":
"695875dd4c75b268f423628eae300a700e156751"}

[commit-bot: I haz the power, 2017-01-17 15:51:35]

Description was changed from

==========
cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG=679837
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Compute RenderSurfaceImpl's TransformTreeIndex using its effect node

This makes RenderSurfaceImpl::TransformTreeIndex use the surface's effect
node rather than its owning layer to find its transform id. For non-root
surfaces, the transform id from the effect node matches the id we
previously got from the owning layer. For the root surface, the id on
the effect node is kRootNodeId (that is, 0) while we previously got
kContentsRootNodeId (that is, 1) from the owning layer; returning
kRootNodeId makes more sense since the draw transform and screen space
transform for the root render surface are defined to be the identity,
and don't include the transform from node 1 to node 0.

BUG=679837
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2632313002
Cr-Commit-Position: refs/heads/master@{#444060}
Committed:
https://chromium.googlesource.com/chromium/src/+/695875dd4c75b268f423628eae30...
==========

[commit-bot: I haz the power, 2017-01-17 15:51:36]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/695875dd4c75b268f423628eae30...