Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2639613002: cc: Remove calls to owning_layer_->DrawTransform in RenderSurfaceImpl (Closed)

Created:
3 years, 11 months ago by ajuma
Modified:
3 years, 11 months ago
Reviewers:
jaydasika, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove calls to owning_layer_->DrawTransform in RenderSurfaceImpl This replaces calls to owning_layer_->DrawTransform with calls to OwningEffectNode()->surface_contents_scale. Since this removes the last remaining use of owning_layer_, this also deletes RenderSurfaceImpl::owning_layer_. BUG=611883, 679836 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2639613002 Cr-Commit-Position: refs/heads/master@{#444158} Committed: https://chromium.googlesource.com/chromium/src/+/0cf25b2f6bac451a6b6449398e30809607ec37bb

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M cc/layers/render_surface_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/render_surface_impl.cc View 5 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
ajuma
3 years, 11 months ago (2017-01-17 18:40:42 UTC) #8
jaydasika
lgtm
3 years, 11 months ago (2017-01-17 19:21:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639613002/20001
3 years, 11 months ago (2017-01-17 21:53:44 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:59:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0cf25b2f6bac451a6b6449398e30...

Powered by Google App Engine
This is Rietveld 408576698