Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2632283002: Use more generic approach to pack java resources into final APK. (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
Reviewers:
F
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use more generic approach to pack java resources into final APK. Some non-Android Java libraries (in particular, Emma) expect their resources to be packed into JARs and accessible via methods of Class or ClassLoader. This way is supported on Android as well, such resources must be packed into the final APK to be usable. This CL generalizes a way Emma resources are packed into the APK. Instead of having a special case in apkbuilder.py a notion of java resources JAR is added. Any prebuilt JAR can specify that it also contains resources. Then apkbuilder.py will get a list of all such JARs via buildconfig file and pack all resources into an APK. Patched & rebased from: https://codereview.chromium.org/2212443002/ Review-Url: https://codereview.chromium.org/2632283002 Cr-Commit-Position: refs/heads/master@{#443944} Committed: https://chromium.googlesource.com/chromium/src/+/7e46930f3962ed463e08191285a80d66b265c2bb

Patch Set 1 #

Patch Set 2 : GypList->GnList #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -24 lines) Patch
M build/android/gyp/apkbuilder.py View 1 6 chunks +16 lines, -15 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +18 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 6 chunks +16 lines, -8 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
agrieve
On 2017/01/16 18:12:51, agrieve wrote: > The CQ bit was checked by mailto:agrieve@chromium.org to run ...
3 years, 11 months ago (2017-01-16 18:13:00 UTC) #4
F
lgtm
3 years, 11 months ago (2017-01-16 21:27:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2632283002/20001
3 years, 11 months ago (2017-01-16 21:28:04 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 21:33:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e46930f3962ed463e08191285a8...

Powered by Google App Engine
This is Rietveld 408576698