Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2212443002: Use more generic approach to pack java resources into final APK. (Closed)

Created:
4 years, 4 months ago by mlopatkin
Modified:
3 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use more generic approach to pack java resources into final APK. Some non-Android Java libraries (in particular, Emma) expect their resources to be packed into JARs and accessible via methods of Class or ClassLoader. This way is supported on Android as well, such resources must be packed into the final APK to be usable. This CL generalizes a way Emma resources are packed into the APK. Instead of having a special case in apkbuilder.py a notion of java resources JAR is added. Any prebuilt JAR can specify that it also contains resources. Then apkbuilder.py will get a list of all such JARs via buildconfig file and pack all resources into an APK.

Patch Set 1 #

Patch Set 2 : Use the original JAR as the source of resources. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -24 lines) Patch
M build/android/gyp/apkbuilder.py View 6 chunks +16 lines, -15 lines 0 comments Download
M build/android/gyp/write_build_config.py View 2 chunks +18 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 6 chunks +16 lines, -8 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
agrieve
Seems to me like a nicer way to handle resources. lgtm!
4 years, 4 months ago (2016-08-10 02:22:46 UTC) #2
agrieve
Do you still want to submit this?
3 years, 11 months ago (2017-01-13 18:43:38 UTC) #8
agrieve
On 2017/01/13 18:43:38, agrieve wrote: > Do you still want to submit this? Forked this ...
3 years, 11 months ago (2017-01-16 21:16:09 UTC) #9
mlopatkin
3 years, 11 months ago (2017-01-17 11:13:33 UTC) #10
Message was sent while issue was closed.
On 2017/01/16 21:16:09, agrieve wrote:
> On 2017/01/13 18:43:38, agrieve wrote:
> > Do you still want to submit this?
> 
> Forked this for submit here: https://codereview.chromium.org/2632283002/

Thank you for submitting this. As usually happens, urgent tasks came and I
forgot about the CL. I'm really sorry about this.

Powered by Google App Engine
This is Rietveld 408576698