Provide a CSSParserContext to CSSSyntaxDescriptor

Provide a CSSParserContext to CSSSyntaxDescriptor

Add a CSSParserContext* argument to CSSSyntaxDescriptor::parse to allow
CSSValues to be resolve against a proper parser context, and resolve
relative URLs and other sourcing sensitive data.
Provide parser contexts as available on call-sites, or use the
strictCSSParserContext() if none is available. Move the TODO up the
callstack as needed.

BUG=618165
Review-Url: https://codereview.chromium.org/2632083002
Cr-Commit-Position: refs/heads/master@{#443882}
Committed: https://chromium.googlesource.com/chromium/src/+/9f693fb8bdcda52ef30230ff57592a9736707dff

[fs, 2017-01-15 18:58:06]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 18:58:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-15 20:21:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 20:21:52]

Dry run: This issue passed the CQ dry run.

[fs, 2017-01-15 20:30:27]

fs@opera.com changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2017-01-16 00:33:37]

https://codereview.chromium.org/2632083002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/PropertyRegistration.cpp (right):

https://codereview.chromium.org/2632083002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/PropertyRegistration.cpp:112:
tokenizer.tokenRange(), strictCSSParserContext(), isAnimationTainted);
This is probably not right, I think we need a proper context here to let you
register a property with an initialValue of (e.g.) url(relative.png) and have it
work? Maybe document->elementSheet().contents()->parserContext() would work?

[Timothy Loh, 2017-01-16 03:07:14]

On 2017/01/16 00:33:37, Timothy Loh wrote:
>
https://codereview.chromium.org/2632083002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/css/PropertyRegistration.cpp (right):
> 
>
https://codereview.chromium.org/2632083002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/PropertyRegistration.cpp:112:
> tokenizer.tokenRange(), strictCSSParserContext(), isAnimationTainted);
> This is probably not right, I think we need a proper context here to let you
> register a property with an initialValue of (e.g.) url(relative.png) and have
it
> work? Maybe document->elementSheet().contents()->parserContext() would work?

Aside from this, lgtm

[fs, 2017-01-16 10:04:32]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 10:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 13:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 13:17:04]

Dry run: This issue passed the CQ dry run.

[fs, 2017-01-16 13:18:01]

https://codereview.chromium.org/2632083002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/PropertyRegistration.cpp (right):

https://codereview.chromium.org/2632083002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/PropertyRegistration.cpp:112:
tokenizer.tokenRange(), strictCSSParserContext(), isAnimationTainted);
On 2017/01/16 at 00:33:36, Timothy Loh wrote:
> This is probably not right, I think we need a proper context here to let you
register a property with an initialValue of (e.g.) url(relative.png) and have it
work? Maybe document->elementSheet().contents()->parserContext() would work?

Thanks, fixed.

[fs, 2017-01-16 13:18:08]

The CQ bit was checked by fs@opera.com

[fs, 2017-01-16 13:18:08]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2632083002/#ps20001
(title: "Fix parser context in PropertyRegistration")

[commit-bot: I haz the power, 2017-01-16 13:18:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 13:22:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484572688190540,
"parent_rev": "e0e601196ccc3b9f914c04838d76c388774a1c9a", "commit_rev":
"9f693fb8bdcda52ef30230ff57592a9736707dff"}

[commit-bot: I haz the power, 2017-01-16 13:22:38]

Description was changed from

==========
Provide a CSSParserContext to CSSSyntaxDescriptor

Add a CSSParserContext* argument to CSSSyntaxDescriptor::parse to allow
CSSValues to be resolve against a proper parser context, and resolve
relative URLs and other sourcing sensitive data.
Provide parser contexts as available on call-sites, or use the
strictCSSParserContext() if none is available. Move the TODO up the
callstack as needed.

BUG=618165
==========

to

==========
Provide a CSSParserContext to CSSSyntaxDescriptor

Add a CSSParserContext* argument to CSSSyntaxDescriptor::parse to allow
CSSValues to be resolve against a proper parser context, and resolve
relative URLs and other sourcing sensitive data.
Provide parser contexts as available on call-sites, or use the
strictCSSParserContext() if none is available. Move the TODO up the
callstack as needed.

BUG=618165

Review-Url: https://codereview.chromium.org/2632083002
Cr-Commit-Position: refs/heads/master@{#443882}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f693fb8bdcda52ef30230ff5759...
==========

[commit-bot: I haz the power, 2017-01-16 13:22:40]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9f693fb8bdcda52ef30230ff5759...