Provide a CSSParserContext to CSSSyntaxDescriptor

third_party/WebKit/Source/core/css/PropertyRegistration.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/PropertyRegistration.h"
 
 #include "core/animation/CSSValueInterpolationType.h"
 #include "core/css/CSSSyntaxDescriptor.h"
 #include "core/css/CSSValueList.h"
 #include "core/css/CSSVariableReferenceValue.h"
 #include "core/css/PropertyDescriptor.h"
 #include "core/css/PropertyRegistry.h"
+#include "core/css/parser/CSSParserContext.h"
 #include "core/css/parser/CSSTokenizer.h"
 #include "core/css/parser/CSSVariableParser.h"
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/StyleChangeReason.h"
 
 namespace blink {
 
 static bool computationallyIndependent(const CSSValue& value) {
   DCHECK(!value.isCSSWideKeyword());
@@ skipping 77 matching lines @@
         "The syntax provided is not a valid custom property syntax.");
     return;
   }
 
   InterpolationTypes interpolationTypes =
       interpolationTypesForSyntax(atomicName, syntaxDescriptor);
 
   if (descriptor.hasInitialValue()) {
     CSSTokenizer tokenizer(descriptor.initialValue());
     bool isAnimationTainted = false;
-    const CSSValue* initial =
-        syntaxDescriptor.parse(tokenizer.tokenRange(), isAnimationTainted);
+    const CSSValue* initial = syntaxDescriptor.parse(
+        tokenizer.tokenRange(), strictCSSParserContext(), isAnimationTainted);

[Timothy Loh, 2017/01/16 00:33:36]

This is probably not right, I think we need a proper context here to let you
register a property with an initialValue of (e.g.) url(relative.png) and have it
work? Maybe document->elementSheet().contents()->parserContext() would work?

[fs, 2017/01/16 13:18:01]

Thanks, fixed.

     if (!initial) {
       exceptionState.throwDOMException(
           SyntaxError,
           "The initial value provided does not parse for the given syntax.");
       return;
     }
     if (!computationallyIndependent(*initial)) {
       exceptionState.throwDOMException(
           SyntaxError,
           "The initial value provided is not computationally independent.");
@@ skipping 16 matching lines @@
                               std::move(interpolationTypes));
   }
 
   // TODO(timloh): Invalidate only elements with this custom property set
   document->setNeedsStyleRecalc(SubtreeStyleChange,
                                 StyleChangeReasonForTracing::create(
                                     StyleChangeReason::PropertyRegistration));
 }
 
 }  // namespace blink