Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issue 263203003: [New Multicolumn] Guard against zero or negative space shortage. (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)
Modified:
6 years, 7 months ago
CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New Multicolumn] Guard against zero or negative space shortage. We need positive values in order to get anywhere when stretching columns in order to balance them, and we may get called with zero or negative values when there's zero-height content at column boundaries, or when we set an early break in order to honor widows in the next column. BUG=369985 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174088

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review. #

Total comments: 6

Patch Set 3 : rebase master #

Patch Set 4 : code review #

Patch Set 5 : Well, duh... better update the test expectations too, now that we have description() #

Patch Set 6 : rebase master #

Patch Set 7 : Remove failing test. Need to fix an additional issue first. Test will be attached to the CL fixing … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -0 lines) Patch
A LayoutTests/fast/multicol/widows.html View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/widows-expected.txt View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/widows2.html View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/widows2-expected.txt View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-05 14:49:12 UTC) #1
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-06 07:49:28 UTC) #2
rune
non-owner rslgtm with nits. The code change sounds reasonable, but I don't know enough about ...
6 years, 7 months ago (2014-05-06 09:00:06 UTC) #3
mstensho (USE GERRIT)
On 2014/05/06 09:00:06, rune wrote: > Note: I find it easier to review new files ...
6 years, 7 months ago (2014-05-06 09:17:32 UTC) #4
mstensho (USE GERRIT)
https://codereview.chromium.org/263203003/diff/1/LayoutTests/fast/multicol/widows.html File LayoutTests/fast/multicol/widows.html (right): https://codereview.chromium.org/263203003/diff/1/LayoutTests/fast/multicol/widows.html#newcode5 LayoutTests/fast/multicol/widows.html:5: testRunner.dumpAsText(); On 2014/05/06 09:00:06, rune wrote: > > Unnecessary. ...
6 years, 7 months ago (2014-05-06 09:17:39 UTC) #5
mstensho (USE GERRIT)
Code review.
6 years, 7 months ago (2014-05-06 09:18:08 UTC) #6
Julien - ping for review
lgtm https://codereview.chromium.org/263203003/diff/20001/LayoutTests/fast/multicol/widows2.html File LayoutTests/fast/multicol/widows2.html (right): https://codereview.chromium.org/263203003/diff/20001/LayoutTests/fast/multicol/widows2.html#newcode6 LayoutTests/fast/multicol/widows2.html:6: </script> Description of the test? https://codereview.chromium.org/263203003/diff/20001/LayoutTests/fast/multicol/widows2.html#newcode8 LayoutTests/fast/multicol/widows2.html:8: <div ...
6 years, 7 months ago (2014-05-07 01:12:07 UTC) #7
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 7 months ago (2014-05-07 05:52:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/263203003/50001
6 years, 7 months ago (2014-05-07 05:53:40 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 07:03:45 UTC) #10
mstensho (USE GERRIT)
https://codereview.chromium.org/263203003/diff/20001/LayoutTests/fast/multicol/widows2.html File LayoutTests/fast/multicol/widows2.html (right): https://codereview.chromium.org/263203003/diff/20001/LayoutTests/fast/multicol/widows2.html#newcode6 LayoutTests/fast/multicol/widows2.html:6: </script> On 2014/05/07 01:12:07, Julien Chaffraix - PST wrote: ...
6 years, 7 months ago (2014-05-07 07:33:39 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #2). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 08:13:45 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-07 08:47:16 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink mac_blink_rel on tryserver.blink
6 years, 7 months ago (2014-05-07 08:47:16 UTC) #14
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 7 months ago (2014-05-07 09:13:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/263203003/70001
6 years, 7 months ago (2014-05-07 09:15:13 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 10:26:36 UTC) #17
mstensho (USE GERRIT)
The CQ bit was unchecked by mstensho@opera.com
6 years, 7 months ago (2014-05-07 11:28:37 UTC) #18
mstensho (USE GERRIT)
One of the tests crashes (assertion failure). Need to land a patch (not uploaded yet) ...
6 years, 7 months ago (2014-05-07 11:44:36 UTC) #19
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 7 months ago (2014-05-15 13:50:19 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/263203003/110001
6 years, 7 months ago (2014-05-15 13:50:29 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 15:02:07 UTC) #22
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 15:44:44 UTC) #23
Message was sent while issue was closed.
Change committed as 174088

Powered by Google App Engine
This is Rietveld 408576698