LayoutTests/fast/multicol/widows.html - Issue 263203003: [New Multicolumn] Guard against zero or negative space shortage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/widows.html

Issue 263203003: [New Multicolumn] Guard against zero or negative space shortage. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash-expected.txt ('k') | LayoutTests/fast/multicol/widows-expected.txt » ('j') | LayoutTests/fast/multicol/widows2.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 if (window.testRunner)

	5 testRunner.dumpAsText();
	rune 2014/05/06 09:00:06 Unnecessary. Unnecessary. mstensho (USE GERRIT) 2014/05/06 09:17:40 Done. Show quoted text On 2014/05/06 09:00:06, rune wrote: > > Unnecessary. Done.
	6 if (window.internals)

	7 internals.settings.setRegionBasedColumnsEnabled(true);

	8 </script>

	9 <p>The 5 lines should all be in the second column.</p>

	10 <div id="mc" style="-webkit-columns:3; columns:3; -webkit-column-rule:solid; lin e-height:50px; orphans:1; widows:5;">

	11 <span id="inFirstColumn"><br></span>

	12 <span id="first">line<br></span>

	13 line<br>

	14 line<br>

	15 line<br>

	16 <span id="last">line<br></span>

	17 </div>

	18 <script>

	19 shouldBe("mc.offsetHeight", "250");

	20 shouldBe("first.offsetTop", "inFirstColumn.offsetTop");

	21 shouldBeGreaterThan("first.offsetLeft", "inFirstColumn.offsetLeft");

	22 shouldBe("last.offsetLeft", "first.offsetLeft");

	23 </script>

OLD	NEW