LayoutTests/fast/multicol/widows2.html - Issue 263203003: [New Multicolumn] Guard against zero or negative space shortage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/widows2.html

Issue 263203003: [New Multicolumn] Guard against zero or negative space shortage. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <script>

	4 if (window.internals)

	5 internals.settings.setRegionBasedColumnsEnabled(true);

	6 </script>
	Julien - ping for review 2014/05/07 01:12:07 Description of the test? Description of the test? mstensho (USE GERRIT) 2014/05/07 07:33:40 Done. Show quoted text On 2014/05/07 01:12:07, Julien Chaffraix - PST wrote: > Description of the test? Done.
	7 <p>There should be 6 lines in the first column, 5 in the second and 5 in the las t one.</p>

	8 <div id="mc" style="-webkit-columns:3; columns:3; -webkit-column-rule:solid; lin e-height:50px;">
	Julien - ping for review 2014/05/07 01:12:07 Do we need to use the prefixed properties? Do we need to use the prefixed properties? mstensho (USE GERRIT) 2014/05/07 07:33:40 Yes, that's the only thing Blink supports. Should Show quoted text On 2014/05/07 01:12:07, Julien Chaffraix - PST wrote: > Do we need to use the prefixed properties? Yes, that's the only thing Blink supports. Should remove prefixes once this new multicol implementation is enabled by default.
	9 <div style="orphans:1; widows:5;">
	Julien - ping for review 2014/05/07 01:12:07 It seems like we don't use the orphan rule so coul It seems like we don't use the orphan rule so could it be removed? mstensho (USE GERRIT) 2014/05/07 07:33:40 According to the spec (CSS 2.1), the initial value Show quoted text On 2014/05/07 01:12:07, Julien Chaffraix - PST wrote: > It seems like we don't use the orphan rule so could it be removed? According to the spec (CSS 2.1), the initial value for 'orphans' is '2', which I don't want. Not that Blink actually implements this exactly like the spec says, but that's a different issue.
	10 line<br>

	11 line<br>

	12 line<br>

	13 line<br>

	14 line<br>

	15 line<br>

	16 line<br>

	17 line<br>

	18 line<br>

	19 line<br>

	20 line<br>

	21 line<br>

	22 line<br>

	23 line<br>

	24 line<br>

	25 line<br>

	26 </div>

	27 </div>

	28 <script>

	29 shouldBe("mc.offsetHeight", "300");

	30 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/multicol/widows-expected.txt ('k') | LayoutTests/fast/multicol/widows2-expected.txt » ('j') | no next file with comments »