Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2631913002: MD Settings: tweak some strings, courtesy of our new UX writer (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: tweak some strings, courtesy of our new UX writer "Less technical" strings to come soon. R=dpapad@chromium.org BUG=681232 Review-Url: https://codereview.chromium.org/2631913002 Cr-Commit-Position: refs/heads/master@{#443757} Committed: https://chromium.googlesource.com/chromium/src/+/ad4e3be7f74e534e1a845f133d25e1c45cb537ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M chrome/app/settings_chromium_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_google_chrome_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/settings_strings.grdp View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Dan Beam
verified each string in the UI as well
3 years, 11 months ago (2017-01-14 00:36:49 UTC) #1
dpapad
lgtm
3 years, 11 months ago (2017-01-14 01:12:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631913002/1
3 years, 11 months ago (2017-01-14 01:18:03 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:22:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad4e3be7f74e534e1a845f133d25...

Powered by Google App Engine
This is Rietveld 408576698