Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2631873002: [Merge M56] Fig memory corruption during launching an app from shortcut. (Closed)

Created:
3 years, 11 months ago by khmel
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Merge M56] Fig memory corruption during launching an app from shortcut. This fix memory corruption crash when app is launched from shelf shortcut. TEST=Manually, crash is no longer observed. BUG=676392 NOTRY=true NOPRESUBMIT=true TBR=skuhne@chromium.org Review-Url: https://codereview.chromium.org/2612453002 Cr-Commit-Position: refs/heads/master@{#441280} (cherry picked from commit d5ab8ce0e2a1a7b6a8e3e003878768b8dc124f1e) Review-Url: https://codereview.chromium.org/2631873002 Cr-Commit-Position: refs/branch-heads/2924@{#765} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/be037ef6060f2d5cd5c0a12d2ccd59492bf767f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631873002/1
3 years, 11 months ago (2017-01-13 23:51:40 UTC) #2
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 23:54:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/be037ef6060f2d5cd5c0a12d2ccd...

Powered by Google App Engine
This is Rietveld 408576698