Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2612453002: Fix memory corruption during launching an app from shortcut. (Closed)

Created:
3 years, 11 months ago by khmel
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory corruption during launching an app from shortcut. This fix memory corruption crash when app is launched from shelf shortcut. TEST=Manually, crash is no longer observed. BUG=676392 Committed: https://crrev.com/d5ab8ce0e2a1a7b6a8e3e003878768b8dc124f1e Cr-Commit-Position: refs/heads/master@{#441280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
khmel
Hi Stephan, PTAL
3 years, 11 months ago (2017-01-03 15:40:15 UTC) #7
Mr4D (OOO till 08-26)
lgtm
3 years, 11 months ago (2017-01-04 00:48:15 UTC) #8
khmel
Thanks!
3 years, 11 months ago (2017-01-04 00:48:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612453002/1
3 years, 11 months ago (2017-01-04 00:49:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 01:24:58 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 01:29:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5ab8ce0e2a1a7b6a8e3e003878768b8dc124f1e
Cr-Commit-Position: refs/heads/master@{#441280}

Powered by Google App Engine
This is Rietveld 408576698