Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2631863002: MD Settings: Use "change" event instead of "blur" for settings-input. (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Use "change" event instead of "blur" for settings-input. Update the pref on the "change" event instead of the "blur" event. The "change" event is fired when the user presses the Enter key. It also is notably not fired if the value stays the same and the input is blurred. BUG=622816 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2631863002 Cr-Commit-Position: refs/heads/master@{#443756} Committed: https://chromium.googlesource.com/chromium/src/+/604d8749c2e91c437dc6e7e0e2d541fb28770527

Patch Set 1 #

Patch Set 2 : Update implementation #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/settings/controls/settings_input.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.js View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
tommycli
dbeam: PTAL. I tried fairly hard to write a test for this, but MockInteractions.pressAndReleaseKey and ...
3 years, 11 months ago (2017-01-13 23:55:50 UTC) #3
Dan Beam
lgtm
3 years, 11 months ago (2017-01-14 00:01:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631863002/40001
3 years, 11 months ago (2017-01-14 00:07:40 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:15:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/604d8749c2e91c437dc6e7e0e2d5...

Powered by Google App Engine
This is Rietveld 408576698