MD Settings: Update some ChromeOS inputs to on-change

MD Settings: Update some ChromeOS inputs to on-change

To fire on the Enter key, and only fire when the value changes, change
the listened event on some ChromeOS inputs from on-blur to on-change.

BUG=622816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[tommycli, 2017-01-14 00:38:43]

Description was changed from

==========
MD Settings: Update some ChromeOS inputs to on-change

To fire on the Enter key, and only fire when the value changes, change
the listened event on some ChromeOS inputs from on-blur to on-change.

BUG=622816
==========

to

==========
MD Settings: Update some ChromeOS inputs to on-change

To fire on the Enter key, and only fire when the value changes, change
the listened event on some ChromeOS inputs from on-blur to on-change.

BUG=622816
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-01-14 00:39:42]

tommycli@chromium.org changed reviewers:
+ stevenjb@chromium.org

[tommycli, 2017-01-14 00:39:42]

stevenjb: PTAL

Same rationale as https://codereview.chromium.org/2632783003/, but sending to
you, as I'm not completely sure about the context of these ChromeOS changes.

[tommycli, 2017-01-14 00:40:06]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 00:40:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 01:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 01:41:13]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-01-17 17:49:33]

Thanks! I tested this and don't see any problems. lgtm

https://codereview.chromium.org/2624213008/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
(right):

https://codereview.chromium.org/2624213008/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_printer_details_page.html:23:
on-change="onValueChanged_">
nit: onValueChange_ while we are at it...

[tommycli, 2017-01-17 18:18:23]

thanks!

https://codereview.chromium.org/2624213008/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
(right):

https://codereview.chromium.org/2624213008/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_printer_details_page.html:23:
on-change="onValueChanged_">
On 2017/01/17 17:49:32, stevenjb wrote:
> nit: onValueChange_ while we are at it...

Done.

[tommycli, 2017-01-17 18:18:26]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-01-17 18:18:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2624213008/#ps20001
(title: "fix issue")

[commit-bot: I haz the power, 2017-01-17 18:19:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 19:31:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484677106479440,
"parent_rev": "401cb387efc0236740281366d2c959f443022ee1", "commit_rev":
"83d63d4b6acb4af448f5532f0ca7fee1828dae32"}

[commit-bot: I haz the power, 2017-01-17 19:37:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 19:37:18]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[tommycli, 2017-01-17 22:02:06]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-01-17 22:02:28]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-01-17 22:03:26]

On 2017/01/17 19:37:18, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Landed, but CQ messed up. Closing issue.

commit 83d63d4b6acb4af448f5532f0ca7fee1828dae32
Author: tommycli <tommycli@chromium.org>
Date:   Tue Jan 17 11:31:10 2017 -0800

    MD Settings: Update some ChromeOS inputs to on-change
    
    To fire on the Enter key, and only fire when the value changes, change
    the listened event on some ChromeOS inputs from on-blur to on-change.
    
    BUG=622816
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2624213008
    Cr-Commit-Position: refs/heads/master@{#444109}