Issue 2631763002: Explicitly mark empty snapshots as extern.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2631763002: Explicitly mark empty snapshots as extern. (Closed)

Created:
3 years, 11 months ago by rmacnak

Modified:
3 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Explicitly mark empty snapshots as extern. TBR=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/422afa2eadb57eb50bd763d4cc3f790f63fc6fc2

Patch Set 1 #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/bin/snapshot_empty.cc	View		1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

Committed patchset #1 (id:1) manually as 422afa2eadb57eb50bd763d4cc3f790f63fc6fc2 (presubmit successful).

3 years, 11 months ago (2017-01-13 18:59:14 UTC) #2

siva

3 years, 11 months ago (2017-01-13 19:03:16 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/2631763002/diff/1/runtime/bin/snapshot_empty.cc
File runtime/bin/snapshot_empty.cc (right):

https://codereview.chromium.org/2631763002/diff/1/runtime/bin/snapshot_empty....
runtime/bin/snapshot_empty.cc:20: extern const uint8_t* const
core_isolate_snapshot_buffer = NULL;
I don't think this is correct.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages