runtime/bin/snapshot_empty.cc - Issue 2631763002: Explicitly mark empty snapshots as extern.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/bin/snapshot_empty.cc

Issue 2631763002: Explicitly mark empty snapshots as extern. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 // This file is linked into the dart executable when it does not have a	5 // This file is linked into the dart executable when it does not have a

6 // snapshot linked into it.	6 // snapshot linked into it.

7	7

8 #if defined(_WIN32)	8 #if defined(_WIN32)

9 typedef unsigned __int8 uint8_t;	9 typedef unsigned __int8 uint8_t;

10 #else	10 #else

11 #include <inttypes.h>	11 #include <inttypes.h>

12 #include <stdint.h>	12 #include <stdint.h>

13 #endif	13 #endif

14 #include <stddef.h>	14 #include <stddef.h>

15	15

16 namespace dart {	16 namespace dart {

17 namespace bin {	17 namespace bin {

18	18

19 const uint8_t* vm_isolate_snapshot_buffer = NULL;	19 extern const uint8_t* vm_isolate_snapshot_buffer = NULL;

20 const uint8_t* const core_isolate_snapshot_buffer = NULL;	20 extern const uint8_t* const core_isolate_snapshot_buffer = NULL;
	siva 2017/01/13 19:03:15 I don't think this is correct. I don't think this is correct.
21	21

22 } // namespace bin	22 } // namespace bin

23 } // namespace dart	23 } // namespace dart

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »