Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/bin/snapshot_empty.cc

Issue 2631763002: Explicitly mark empty snapshots as extern. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/snapshot_empty.cc
diff --git a/runtime/bin/snapshot_empty.cc b/runtime/bin/snapshot_empty.cc
index 6fc5b9f67bd4df428729fe0135faad8965cc00ce..2f122986e48c193da8d7c3339f0b51dca46f6780 100644
--- a/runtime/bin/snapshot_empty.cc
+++ b/runtime/bin/snapshot_empty.cc
@@ -16,8 +16,8 @@ typedef unsigned __int8 uint8_t;
namespace dart {
namespace bin {
-const uint8_t* vm_isolate_snapshot_buffer = NULL;
-const uint8_t* const core_isolate_snapshot_buffer = NULL;
+extern const uint8_t* vm_isolate_snapshot_buffer = NULL;
+extern const uint8_t* const core_isolate_snapshot_buffer = NULL;
siva 2017/01/13 19:03:15 I don't think this is correct.
} // namespace bin
} // namespace dart
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698