Chromium Code Reviews
DescriptionRevert of [Android] Stop using universal_newlines in the layout tests server constructor. (patchset #2 id:20001 of https://codereview.chromium.org/2629113005/ )
Reason for revert:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/59416
Original issue's description:
> [Android] Stop using universal_newlines in the layout tests server constructor.
>
> This had previously been necessary when spawning adb instances with the
> server constructor, as adb mangles newlines. Starting with
> https://codereview.chromium.org/2540603004/, the android port no longer
> spins up adb shells with the server constructor, so we no longer need to
> use universal_newlines. This also means we no longer need to encode crash
> streams back into bytes from text, as they're not converted to text in the
> first place.
>
> BUG=679723, 496983
>
> Review-Url: https://codereview.chromium.org/2629113005
> Cr-Commit-Position: refs/heads/master@{#443621}
> Committed: https://chromium.googlesource.com/chromium/src/+/f7be987d1b081aa826af6d842e27608dd47a7cff
TBR=qyearsley@chromium.org,jeffcarp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679723, 496983
Review-Url: https://codereview.chromium.org/2631743003
Cr-Commit-Position: refs/heads/master@{#443693}
Committed: https://chromium.googlesource.com/chromium/src/+/5489020f1edea26f4256621b874afebf7425fdf0
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||