Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2631743003: Revert of [Android] Stop using universal_newlines in the layout tests server constructor. (Closed)

Created:
3 years, 11 months ago by jbudorick
Modified:
3 years, 8 months ago
Reviewers:
qyearsley, jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Stop using universal_newlines in the layout tests server constructor. (patchset #2 id:20001 of https://codereview.chromium.org/2629113005/ ) Reason for revert: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/59416 Original issue's description: > [Android] Stop using universal_newlines in the layout tests server constructor. > > This had previously been necessary when spawning adb instances with the > server constructor, as adb mangles newlines. Starting with > https://codereview.chromium.org/2540603004/, the android port no longer > spins up adb shells with the server constructor, so we no longer need to > use universal_newlines. This also means we no longer need to encode crash > streams back into bytes from text, as they're not converted to text in the > first place. > > BUG=679723, 496983 > > Review-Url: https://codereview.chromium.org/2629113005 > Cr-Commit-Position: refs/heads/master@{#443621} > Committed: https://chromium.googlesource.com/chromium/src/+/f7be987d1b081aa826af6d842e27608dd47a7cff TBR=qyearsley@chromium.org,jeffcarp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=679723, 496983 Review-Url: https://codereview.chromium.org/2631743003 Cr-Commit-Position: refs/heads/master@{#443693} Committed: https://chromium.googlesource.com/chromium/src/+/5489020f1edea26f4256621b874afebf7425fdf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 2 chunks +14 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
Created Revert of [Android] Stop using universal_newlines in the layout tests server constructor.
3 years, 11 months ago (2017-01-13 22:08:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631743003/1
3 years, 11 months ago (2017-01-13 22:09:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5489020f1edea26f4256621b874afebf7425fdf0
3 years, 11 months ago (2017-01-13 22:10:44 UTC) #6
qyearsley
3 years, 8 months ago (2017-04-20 20:54:30 UTC) #7
Message was sent while issue was closed.
lgtm

(Going through old CLs that I hadn't responded to...)

Powered by Google App Engine
This is Rietveld 408576698