Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2629113005: [Android] Stop using universal_newlines in the layout tests server constructor. (Closed)

Created:
3 years, 11 months ago by jbudorick
Modified:
3 years, 11 months ago
Reviewers:
qyearsley, jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Stop using universal_newlines in the layout tests server constructor. This had previously been necessary when spawning adb instances with the server constructor, as adb mangles newlines. Starting with https://codereview.chromium.org/2540603004/, the android port no longer spins up adb shells with the server constructor, so we no longer need to use universal_newlines. This also means we no longer need to encode crash streams back into bytes from text, as they're not converted to text in the first place. BUG=679723, 496983 Review-Url: https://codereview.chromium.org/2629113005 Cr-Commit-Position: refs/heads/master@{#443621} Committed: https://chromium.googlesource.com/chromium/src/+/f7be987d1b081aa826af6d842e27608dd47a7cff

Patch Set 1 #

Patch Set 2 : explain the pylint disable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 2 chunks +2 lines, -14 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_mock.py View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jbudorick
3 years, 11 months ago (2017-01-13 15:10:38 UTC) #3
qyearsley
Excellent, LGTM
3 years, 11 months ago (2017-01-13 17:20:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629113005/20001
3 years, 11 months ago (2017-01-13 17:22:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f7be987d1b081aa826af6d842e27608dd47a7cff
3 years, 11 months ago (2017-01-13 18:35:02 UTC) #9
jbudorick
3 years, 11 months ago (2017-01-13 22:08:44 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2631743003/ by jbudorick@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N....

Powered by Google App Engine
This is Rietveld 408576698