Chromium Code Reviews
Description[Android] Stop using universal_newlines in the layout tests server constructor.
This had previously been necessary when spawning adb instances with the
server constructor, as adb mangles newlines. Starting with
https://codereview.chromium.org/2540603004/, the android port no longer
spins up adb shells with the server constructor, so we no longer need to
use universal_newlines. This also means we no longer need to encode crash
streams back into bytes from text, as they're not converted to text in the
first place.
BUG=679723, 496983
Review-Url: https://codereview.chromium.org/2629113005
Cr-Commit-Position: refs/heads/master@{#443621}
Committed: https://chromium.googlesource.com/chromium/src/+/f7be987d1b081aa826af6d842e27608dd47a7cff
Patch Set 1 #Patch Set 2 : explain the pylint disable #
Messages
Total messages: 10 (5 generated)
|
|||||||||||||||||||||||||||||||||||||