DescriptionRevert of [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for 'beforeinput' (2/3) (patchset #2 id:20001 of https://codereview.chromium.org/2581073003/ )
Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.
Original issue's description:
> [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for 'beforeinput' (2/3)
>
> This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL
> https://crrev.com/2558643003)
>
> This CL:
> 1. Updated calling path |Editor::undo()| =>
> |UndoStack::undo()| =>
> |EditCommandComposition::unapply()| =>
> *|EditCommandComposition::willUnapply()|.
> 2. Similar for redo.
>
> * Marks new methods.
>
> The next step is to fire 'beforeinput' in |EditCommandComposition::willUn/Reapply()|.
>
> This CL shouldn't have any behavior change.
>
> To help reviewing, here is a simple doc describing the following plans:
> https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing
>
> BUG=670035
>
> Committed: https://crrev.com/c6596482a643b73b8cfe7b615639e6fea449e08b
> Cr-Commit-Position: refs/heads/master@{#439640}
TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=670035
Review-Url: https://codereview.chromium.org/2631743002
Cr-Commit-Position: refs/heads/master@{#443664}
Committed: https://chromium.googlesource.com/chromium/src/+/bca99cd5304a9e2a6fb249d7d3c352854752cd69
Patch Set 1 #
Messages
Total messages: 7 (4 generated)
|