Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2631743002: Revert of [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for (2/3) (Closed)

Created:
3 years, 11 months ago by chongz
Modified:
3 years, 11 months ago
Reviewers:
tkent, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for 'beforeinput' (2/3) (patchset #2 id:20001 of https://codereview.chromium.org/2581073003/ ) Reason for revert: We want to revert all CLs and start over the refactor process, see: https://crbug.com/673789. Original issue's description: > [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for 'beforeinput' (2/3) > > This is the second sub-patch (2/3) of unifying 'beforeinput' logic. (Original CL > https://crrev.com/2558643003) > > This CL: > 1. Updated calling path |Editor::undo()| => > |UndoStack::undo()| => > |EditCommandComposition::unapply()| => > *|EditCommandComposition::willUnapply()|. > 2. Similar for redo. > > * Marks new methods. > > The next step is to fire 'beforeinput' in |EditCommandComposition::willUn/Reapply()|. > > This CL shouldn't have any behavior change. > > To help reviewing, here is a simple doc describing the following plans: > https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing > > BUG=670035 > > Committed: https://crrev.com/c6596482a643b73b8cfe7b615639e6fea449e08b > Cr-Commit-Position: refs/heads/master@{#439640} TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=670035 Review-Url: https://codereview.chromium.org/2631743002 Cr-Commit-Position: refs/heads/master@{#443664} Committed: https://chromium.googlesource.com/chromium/src/+/bca99cd5304a9e2a6fb249d7d3c352854752cd69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -42 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 2 chunks +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 3 chunks +2 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStep.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
chongz
Created Revert of [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for 'beforeinput' (2/3)
3 years, 11 months ago (2017-01-13 18:33:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631743002/1
3 years, 11 months ago (2017-01-13 18:36:09 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 20:56:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bca99cd5304a9e2a6fb249d7d3c3...

Powered by Google App Engine
This is Rietveld 408576698