Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2631743002: Revert of [Editing] Introduce |EditCommandComposition::willUn/Reapply()| in prepare for (2/3) (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
index ee81dce271d7319aab59e5652f6a218db8f031a0..8e9f33a1e1d1e1348aee20a445f9137a3502cd4a 100644
--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
@@ -105,13 +105,10 @@
return m_document->frame() == &frame;
}
-void EditCommandComposition::unapply(EditCommandSource source) {
+void EditCommandComposition::unapply() {
DCHECK(m_document);
LocalFrame* frame = m_document->frame();
DCHECK(frame);
-
- if (!willUnapply(source))
- return;
// Changes to the document may have been made since the last editing operation
// that require a layout, as in <rdar://problem/5658603>. Low level
@@ -129,13 +126,10 @@
frame->editor().unappliedEditing(this);
}
-void EditCommandComposition::reapply(EditCommandSource source) {
+void EditCommandComposition::reapply() {
DCHECK(m_document);
LocalFrame* frame = m_document->frame();
DCHECK(frame);
-
- if (!willReapply(source))
- return;
// Changes to the document may have been made since the last editing operation
// that require a layout, as in <rdar://problem/5658603>. Low level
@@ -150,16 +144,6 @@
}
frame->editor().reappliedEditing(this);
-}
-
-bool EditCommandComposition::willUnapply(EditCommandSource) {
- // TODO(chongz): Fire 'beforeinput' for 'historyUndo'.
- return true;
-}
-
-bool EditCommandComposition::willReapply(EditCommandSource) {
- // TODO(chongz): Fire 'beforeinput' for 'historyRedo'.
- return true;
}
InputEvent::InputType EditCommandComposition::inputType() const {

Powered by Google App Engine
This is Rietveld 408576698