Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 263163004: Revert 268167 "Removed dependency on the UI from the NetworkPort..." (Closed)

Created:
6 years, 7 months ago by Albert Bodenhamer
Modified:
6 years, 7 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 268167 "Removed dependency on the UI from the NetworkPort..." Probable cause of break at http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%282%29/builds/28903 > Removed dependency on the UI from the NetworkPortalDetector. > > BUG=363776 > TEST=browser_tests:NetworkPortalDetectorImpl* > R=stevenjb@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267169 > > Review URL: https://codereview.chromium.org/245113003 TBR=ygorshenin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -68 lines) Patch
M trunk/src/chrome/browser/chromeos/login/captive_portal_window_browsertest.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screens/error_screen.h View 4 chunks +15 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/screens/error_screen.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector.h View 3 chunks +4 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector_impl.h View 4 chunks +15 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector_impl.cc View 6 chunks +39 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector_strategy.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector_test_impl.h View 1 chunk +1 line, -7 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/net/network_portal_detector_test_impl.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Albert Bodenhamer
6 years, 7 months ago (2014-05-05 16:29:56 UTC) #1
Albert Bodenhamer
6 years, 7 months ago (2014-05-05 16:30:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r268190 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698