Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: trunk/src/chrome/browser/chromeos/net/network_portal_detector.h

Issue 263163004: Revert 268167 "Removed dependency on the UI from the NetworkPort..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/chromeos/net/network_portal_detector.h
===================================================================
--- trunk/src/chrome/browser/chromeos/net/network_portal_detector.h (revision 268189)
+++ trunk/src/chrome/browser/chromeos/net/network_portal_detector.h (working copy)
@@ -6,7 +6,7 @@
#define CHROME_BROWSER_CHROMEOS_NET_NETWORK_PORTAL_DETECTOR_H_
#include "base/basictypes.h"
-#include "chrome/browser/chromeos/net/network_portal_detector_strategy.h"
+#include "chrome/browser/chromeos/login/screens/error_screen.h"
#include "net/url_request/url_fetcher.h"
namespace chromeos {
@@ -16,7 +16,7 @@
// This class handles all notifications about network changes from
// NetworkStateHandler and delegates portal detection for the active
// network to CaptivePortalService.
-class NetworkPortalDetector {
+class NetworkPortalDetector : public ErrorScreen::Observer {
public:
enum CaptivePortalStatus {
CAPTIVE_PORTAL_STATUS_UNKNOWN = 0,
@@ -96,9 +96,8 @@
// started.
virtual bool StartDetectionIfIdle() = 0;
- // Sets current strategy according to |id|. If current detection id
- // doesn't equal to |id|, detection is restarted.
- virtual void SetStrategy(PortalDetectorStrategy::StrategyId id) = 0;
+ virtual void OnErrorScreenShow() OVERRIDE {}
+ virtual void OnErrorScreenHide() OVERRIDE {}
// Initializes network portal detector for testing. The
// |network_portal_detector| will be owned by the internal pointer

Powered by Google App Engine
This is Rietveld 408576698