Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 245113003: Removed dependency on the UI from the NetworkPortalDetector. (Closed)

Created:
6 years, 8 months ago by ygorshenin1
Modified:
6 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, cbentzel+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Removed dependency on the UI from the NetworkPortalDetector. BUG=363776 TEST=browser_tests:NetworkPortalDetectorImpl* R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267169 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268167 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269134

Patch Set 1 #

Patch Set 2 : Fixed NetworkPortalDetector unittests. #

Total comments: 2

Patch Set 3 : Fix. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fixed test, rebase. #

Patch Set 6 : Restored old behavior of detection, rebase. #

Patch Set 7 : Rebase. #

Patch Set 8 : Fix. #

Patch Set 9 : Rebase. #

Patch Set 10 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -95 lines) Patch
M chrome/browser/chromeos/login/captive_portal_window_browsertest.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.h View 4 chunks +2 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.h View 1 2 3 4 5 6 4 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 1 2 3 4 5 6 7 6 chunks +12 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_strategy.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_test_impl.h View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_test_impl.cc View 3 4 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 37 (0 generated)
ygorshenin1
6 years, 8 months ago (2014-04-21 13:43:38 UTC) #1
stevenjb
This looks much better, than you. LGTM https://codereview.chromium.org/245113003/diff/20001/chrome/browser/chromeos/net/network_portal_detector_test_impl.cc File chrome/browser/chromeos/net/network_portal_detector_test_impl.cc (right): https://codereview.chromium.org/245113003/diff/20001/chrome/browser/chromeos/net/network_portal_detector_test_impl.cc#newcode89 chrome/browser/chromeos/net/network_portal_detector_test_impl.cc:89: PortalDetectorStrategy::StrategyId id) ...
6 years, 8 months ago (2014-04-21 16:53:16 UTC) #2
ygorshenin1
Many thanks! https://codereview.chromium.org/245113003/diff/20001/chrome/browser/chromeos/net/network_portal_detector_test_impl.cc File chrome/browser/chromeos/net/network_portal_detector_test_impl.cc (right): https://codereview.chromium.org/245113003/diff/20001/chrome/browser/chromeos/net/network_portal_detector_test_impl.cc#newcode89 chrome/browser/chromeos/net/network_portal_detector_test_impl.cc:89: PortalDetectorStrategy::StrategyId id) { On 2014/04/21 16:53:16, stevenjb ...
6 years, 8 months ago (2014-04-22 08:42:49 UTC) #3
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 8 months ago (2014-04-22 11:49:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/60001
6 years, 8 months ago (2014-04-22 11:50:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 12:22:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-22 12:22:20 UTC) #7
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 8 months ago (2014-04-22 13:54:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/60001
6 years, 8 months ago (2014-04-22 13:54:19 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 14:23:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-22 14:23:46 UTC) #11
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 8 months ago (2014-04-25 12:23:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/60001
6 years, 8 months ago (2014-04-25 12:39:44 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:13:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-25 23:13:49 UTC) #15
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 7 months ago (2014-04-28 15:17:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/80001
6 years, 7 months ago (2014-04-28 15:17:23 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 15:49:13 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_aosp
6 years, 7 months ago (2014-04-28 15:49:14 UTC) #19
ygorshenin1
Committed patchset #7 manually as r267169 (presubmit successful).
6 years, 7 months ago (2014-04-30 10:54:11 UTC) #20
ygorshenin1
A revert of this CL has been created in https://codereview.chromium.org/254263004/ by ygorshenin@chromium.org. The reason for ...
6 years, 7 months ago (2014-04-30 12:00:21 UTC) #21
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 7 months ago (2014-04-30 12:26:26 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/160001
6 years, 7 months ago (2014-04-30 12:26:53 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 12:29:31 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 12:29:32 UTC) #25
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 7 months ago (2014-05-05 10:20:03 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/180001
6 years, 7 months ago (2014-05-05 10:20:09 UTC) #27
commit-bot: I haz the power
Change committed as 268167
6 years, 7 months ago (2014-05-05 13:28:34 UTC) #28
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 7 months ago (2014-05-07 18:21:09 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/200001
6 years, 7 months ago (2014-05-07 18:21:36 UTC) #30
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 22:04:47 UTC) #31
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 03:18:31 UTC) #32
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 03:51:53 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium
6 years, 7 months ago (2014-05-08 03:51:54 UTC) #34
ygorshenin1
The CQ bit was checked by ygorshenin@chromium.org
6 years, 7 months ago (2014-05-08 08:00:55 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/245113003/200001
6 years, 7 months ago (2014-05-08 08:04:16 UTC) #36
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 01:32:43 UTC) #37
Message was sent while issue was closed. 
Change committed as 269134

Powered by Google App Engine
This is Rietveld 408576698