Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2631543002: Revert of [wasm][asm.js] Turn on asm.js -> WebAssembly by default. (Closed)

Created:
3 years, 11 months ago by xlai (Olivia)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [wasm][asm.js] Turn on asm.js -> WebAssembly by default. (patchset #2 id:20001 of https://codereview.chromium.org/2625823006/ ) Reason for revert: Suspecting this CL is causing these tests to fail: fast/workers/worker-shared-asm-buffer.html virtual/sharedarraybuffer/fast/workers/worker-shared-asm-buffer.html From the layout test results, it seems that turning on asm.js will append some console results to the test outcome. Example build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/22022 Original issue's description: > [wasm][asm.js] Turn on asm.js -> WebAssembly by default. > > BUG=v8:4203 > R=danno@chromium.org,titzer@chromium.org,jochen@chromium.org > > Review-Url: https://codereview.chromium.org/2625823006 > Cr-Commit-Position: refs/heads/master@{#443289} > Committed: https://chromium.googlesource.com/chromium/src/+/7417bea53a78a97ae815479e5d73cf0840d90c88 TBR=jochen@chromium.org,bradnelson@google.com,danno@chromium.org,titzer@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2631543002 Cr-Commit-Position: refs/heads/master@{#443330} Committed: https://chromium.googlesource.com/chromium/src/+/06def717acdab6e6127ca99f90a6300139d03c36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
xlai (Olivia)
Created Revert of [wasm][asm.js] Turn on asm.js -> WebAssembly by default.
3 years, 11 months ago (2017-01-12 19:48:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631543002/1
3 years, 11 months ago (2017-01-12 19:49:44 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:50:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06def717acdab6e6127ca99f90a6...

Powered by Google App Engine
This is Rietveld 408576698