Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2625823006: [wasm][asm.js] Turn on asm.js -> WebAssembly by default. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[wasm][asm.js] Turn on asm.js -> WebAssembly by default. BUG=v8:4203 R=danno@chromium.org,titzer@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2625823006 Cr-Commit-Position: refs/heads/master@{#443289} Committed: https://chromium.googlesource.com/chromium/src/+/7417bea53a78a97ae815479e5d73cf0840d90c88

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/public/common/content_features.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
bradn
3 years, 11 months ago (2017-01-12 02:35:26 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 08:55:19 UTC) #11
titzer
lgtm
3 years, 11 months ago (2017-01-12 17:05:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2625823006/20001
3 years, 11 months ago (2017-01-12 17:18:47 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7417bea53a78a97ae815479e5d73cf0840d90c88
3 years, 11 months ago (2017-01-12 18:01:37 UTC) #17
xlai (Olivia)
3 years, 11 months ago (2017-01-12 19:48:35 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2631543002/ by xlai@chromium.org.

The reason for reverting is: Suspecting this CL is causing these tests to fail:
fast/workers/worker-shared-asm-buffer.html
virtual/sharedarraybuffer/fast/workers/worker-shared-asm-buffer.html

From the layout test results, it seems that turning on asm.js will append some
console results to the test outcome.
Example build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty....

Powered by Google App Engine
This is Rietveld 408576698