Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2631453002: Revert of cc: Add image decode queue functionality to image manager. (Closed)

Created:
3 years, 11 months ago by dschuyler
Modified:
3 years, 11 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Add image decode queue functionality to image manager. (patchset #12 id:220001 of https://codereview.chromium.org/2537683002/ ) Reason for revert: Hoping to fix build/test errors such as https://uberchromegw.corp.google.com/i/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19947 -- sheriff. Original issue's description: > cc: Add image decode queue functionality to image manager. > > This patch adds an ability to request an image decode from > the compositor. The caller should specify which image > (SkImage) to decode and a callback. In return, it gets an > id. When the image is decoded, the callback is issued with > this id. The decode is then kept alive for 2 compositor > frames. > > Right now, only unittests are using this functionality. > > R=enne@chromium.org, ericrk@chromium.org, danakj@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2537683002 > Cr-Commit-Position: refs/heads/master@{#443085} > Committed: https://chromium.googlesource.com/chromium/src/+/bb991d41668aa0f37aa6d6712e3bf9b52a5480ae TBR=enne@chromium.org,danakj@chromium.org,ericrk@chromium.org,vmpstr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2631453002 Cr-Commit-Position: refs/heads/master@{#443125} Committed: https://chromium.googlesource.com/chromium/src/+/1e09c6d2f483f00e88e33b4b5efa82d1c43add43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1200 lines) Patch
M cc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/playback/image_hijack_canvas_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/raster/task.h View 3 chunks +0 lines, -4 lines 0 comments Download
M cc/raster/task.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_tile_manager.h View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/test/fake_tile_manager.cc View 1 chunk +18 lines, -4 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
D cc/tiles/decoded_image_tracker.h View 1 chunk +0 lines, -56 lines 0 comments Download
D cc/tiles/decoded_image_tracker.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D cc/tiles/decoded_image_tracker_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache.h View 5 chunks +2 lines, -19 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache.cc View 10 chunks +21 lines, -65 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache_unittest.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M cc/tiles/image_controller.h View 3 chunks +2 lines, -66 lines 0 comments Download
M cc/tiles/image_controller.cc View 2 chunks +2 lines, -260 lines 0 comments Download
M cc/tiles/image_controller_unittest.cc View 2 chunks +9 lines, -400 lines 0 comments Download
M cc/tiles/image_decode_cache.h View 1 chunk +0 lines, -9 lines 0 comments Download
M cc/tiles/software_image_decode_cache.h View 4 chunks +4 lines, -20 lines 0 comments Download
M cc/tiles/software_image_decode_cache.cc View 9 chunks +10 lines, -54 lines 0 comments Download
M cc/tiles/tile_manager.h View 3 chunks +1 line, -5 lines 0 comments Download
M cc/tiles/tile_manager.cc View 3 chunks +6 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 4 chunks +2 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +3 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 2 chunks +1 line, -4 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dschuyler
Created Revert of cc: Add image decode queue functionality to image manager.
3 years, 11 months ago (2017-01-12 02:35:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631453002/1
3 years, 11 months ago (2017-01-12 02:36:36 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 02:50:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1e09c6d2f483f00e88e33b4b5efa...

Powered by Google App Engine
This is Rietveld 408576698