[compiler] Unify EnsureFeedbackMetadata call sites.

[compiler] Unify EnsureFeedbackMetadata call sites.

This makes sure all call sites allocating and installing the feedback
vector metadata are within the compilation pipeline and avoids spreading
them accross components.

R=leszeks@chromium.org

Review-Url: https://codereview.chromium.org/2631253002
Cr-Commit-Position: refs/heads/master@{#42399}
Committed: https://chromium.googlesource.com/v8/v8/+/28776d0125569315d8ccacc76bddbc763f8e70b9

[Michael Starzinger, 2017-01-16 17:42:07]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 17:42:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 18:07:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 18:07:06]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-01-16 18:15:33]

Description was changed from

==========
[compiler] Unify EnsureFeedbackMetadata call sites.

This makes sure all call sites allocating and installing the feedback
vector metadata are within the compilation pipeline and avoids spreading
them accross components.

R=
==========

to

==========
[compiler] Unify EnsureFeedbackMetadata call sites.

This makes sure all call sites allocating and installing the feedback
vector metadata are within the compilation pipeline and avoids spreading
them accross components.

R=leszeks@chromium.org
==========

[Michael Starzinger, 2017-01-16 18:15:33]

mstarzinger@chromium.org changed reviewers:
+ leszeks@chromium.org, mvstanton@chromium.org

[Michael Starzinger, 2017-01-16 18:19:19]

If you agree with this approach, then I would want to also undo the
{TypeFeedbackMetadata::EnsureAllocated} helper as well and inline it into
{EnsureFeedbackMetadata} again. I'll do so tomorrow.

[Michael Starzinger, 2017-01-17 09:11:30]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 09:11:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 09:36:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 09:36:58]

Dry run: This issue passed the CQ dry run.

[Leszek Swirski, 2017-01-17 10:05:37]

Ah yeah, I was definitely overthinking this. Much cleaner, LGTM.

[rmcilroy, 2017-01-17 10:42:16]

On 2017/01/17 10:05:37, Leszek Swirski wrote:
> Ah yeah, I was definitely overthinking this. Much cleaner, LGTM.

Nice, thanks Michi. LGTM.

[Michael Starzinger, 2017-01-17 11:20:39]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2017-01-17 11:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 11:22:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484652039040840,
"parent_rev": "248d1b3de9872c21df3a92dbaff5c81e2026e0dc", "commit_rev":
"28776d0125569315d8ccacc76bddbc763f8e70b9"}

[commit-bot: I haz the power, 2017-01-17 11:22:23]

Description was changed from

==========
[compiler] Unify EnsureFeedbackMetadata call sites.

This makes sure all call sites allocating and installing the feedback
vector metadata are within the compilation pipeline and avoids spreading
them accross components.

R=leszeks@chromium.org
==========

to

==========
[compiler] Unify EnsureFeedbackMetadata call sites.

This makes sure all call sites allocating and installing the feedback
vector metadata are within the compilation pipeline and avoids spreading
them accross components.

R=leszeks@chromium.org

Review-Url: https://codereview.chromium.org/2631253002
Cr-Commit-Position: refs/heads/master@{#42399}
Committed:
https://chromium.googlesource.com/v8/v8/+/28776d0125569315d8ccacc76bddbc763f8...
==========

[commit-bot: I haz the power, 2017-01-17 11:22:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/28776d0125569315d8ccacc76bddbc763f8...