Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2631253002: [compiler] Unify EnsureFeedbackMetadata call sites. (Closed)
Patch Set: Remove helper method. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-generator.cc
diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc
index 84cd94393e1396888b561e011158672c9c45d0f0..ae56f8ad040ebf67410eddd9e2e81796764349f9 100644
--- a/src/interpreter/bytecode-generator.cc
+++ b/src/interpreter/bytecode-generator.cc
@@ -651,14 +651,6 @@ void BytecodeGenerator::AllocateDeferredConstants(Isolate* isolate) {
array_literal->GetOrBuildConstantElements(isolate);
builder()->InsertConstantPoolEntryAt(literal.second, constant_elements);
}
-
- // TODO(leszeks): ideally there would be no path to here where feedback
- // metadata is previously created, and we could create it unconditionally.
- // We should investigate again once FCG has shuffled off its mortal coil.
- DCHECK(info()->has_shared_info());
- TypeFeedbackMetadata::EnsureAllocated(
- info()->isolate(), info()->shared_info(),
- info()->literal()->feedback_vector_spec());
}
void BytecodeGenerator::GenerateBytecode(uintptr_t stack_limit) {
« no previous file with comments | « src/compiler.cc ('k') | src/type-feedback-vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698