Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2631223002: [modules] Fix NewJSModuleNamespace to avoid GC being able to see incomplete JSModuleNamespace. (Closed)

Created:
3 years, 11 months ago by rmcilroy
Modified:
3 years, 11 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Fix NewJSModuleNamespace to avoid GC being able to see incomplete JSModuleNamespace. A GC could happen when creating the Module string, which would cause the JSModuleNamespace to be seen in an incomplete state. Instead make this string a root object so that we don't need to allocate it during NewJSModuleNamespace construction. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2631223002 Cr-Commit-Position: refs/heads/master@{#42393} Committed: https://chromium.googlesource.com/v8/v8/+/01b684cf6869f52ff37b2a5d584314e07f7028a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
rmcilroy
Georg, I was seeing crashes on GC Stress with an unrelated CL (https://codereview.chromium.org/2630343002/) which showed ...
3 years, 11 months ago (2017-01-16 16:56:24 UTC) #4
neis
On 2017/01/16 16:56:24, rmcilroy wrote: > Georg, I was seeing crashes on GC Stress with ...
3 years, 11 months ago (2017-01-17 09:53:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631223002/1
3 years, 11 months ago (2017-01-17 10:12:08 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 10:14:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/01b684cf6869f52ff37b2a5d584314e07f7...

Powered by Google App Engine
This is Rietveld 408576698