[modules] Define @@toStringTag on namespace object as a field.

[modules] Define @@toStringTag on namespace object as a field.

The constant field tracking implies data constants to be stored
in fields instead of descriptor arrays. This CL does necessary
modifications to the JSModuleNamespace map setup.

BUG=v8:1569, v8:5495
Review-Url: https://codereview.chromium.org/2625093005
Cr-Commit-Position: refs/heads/master@{#42294}
Committed: https://chromium.googlesource.com/v8/v8/+/aee244b0e115f4c3aef56055b739777dde94c3ac

[Igor Sheludko, 2017-01-12 14:58:24]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2017-01-12 14:59:09]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 14:59:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-12 14:59:29]

ishell@chromium.org changed reviewers:
+ neis@chromium.org

[Igor Sheludko, 2017-01-12 14:59:30]

PTAL

[commit-bot: I haz the power, 2017-01-12 15:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:34:36]

Dry run: This issue passed the CQ dry run.

[neis, 2017-01-12 15:57:30]

On 2017/01/12 14:59:30, Igor Sheludko wrote:
> PTAL

lgtm. Could you add an explanation to the description saying what exactly the
problem was?

Thanks.

[Igor Sheludko, 2017-01-12 16:09:02]

Description was changed from

==========
[modules] Properly define @@toStringTag field on namespace object.

This fix has to be done for constant field tracking.

BUG=v8:1569, v8:5495
==========

to

==========
[modules] Define @@toStringTag on namespace object as a field.

The constant field tracking implies data constants to be stored
in fields instead of descriptor arrays. This CL does necessary
modifications to the JSModuleNamespace map setup.

BUG=v8:1569, v8:5495
==========

[Igor Sheludko, 2017-01-12 21:38:22]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-01-12 21:38:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 21:40:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484257102357050,
"parent_rev": "7c7434085ef3f26a3d43e059bee369e61347fe6d", "commit_rev":
"aee244b0e115f4c3aef56055b739777dde94c3ac"}

[commit-bot: I haz the power, 2017-01-12 21:40:09]

Description was changed from

==========
[modules] Define @@toStringTag on namespace object as a field.

The constant field tracking implies data constants to be stored
in fields instead of descriptor arrays. This CL does necessary
modifications to the JSModuleNamespace map setup.

BUG=v8:1569, v8:5495
==========

to

==========
[modules] Define @@toStringTag on namespace object as a field.

The constant field tracking implies data constants to be stored
in fields instead of descriptor arrays. This CL does necessary
modifications to the JSModuleNamespace map setup.

BUG=v8:1569, v8:5495

Review-Url: https://codereview.chromium.org/2625093005
Cr-Commit-Position: refs/heads/master@{#42294}
Committed:
https://chromium.googlesource.com/v8/v8/+/aee244b0e115f4c3aef56055b739777dde9...
==========

[commit-bot: I haz the power, 2017-01-12 21:40:10]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/aee244b0e115f4c3aef56055b739777dde9...