Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2631063003: [api,profiler] Introduce GetRetainerInfos callback for profiling (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api,profiler] Introduce GetRetainerInfos callback for profiling BUG=679724 Review-Url: https://codereview.chromium.org/2631063003 Cr-Commit-Position: refs/heads/master@{#42506} Committed: https://chromium.googlesource.com/v8/v8/+/45b10228abfdc23587bd1cd44eb5c1edc39e41a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M include/v8-profiler.h View 3 chunks +21 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/profiler/heap-profiler.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/profiler/heap-profiler.cc View 2 chunks +15 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
Michael Lippautz
just the api additions; to be landed after branch cut
3 years, 11 months ago (2017-01-16 15:26:12 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-16 15:39:35 UTC) #6
Michael Lippautz
We officially branched. Landing this now, so that we can use it in Chrome once ...
3 years, 11 months ago (2017-01-19 14:00:32 UTC) #9
Michael Lippautz
We officially branched. Landing this now, so that we can use it in Chrome once ...
3 years, 11 months ago (2017-01-19 14:00:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631063003/1
3 years, 11 months ago (2017-01-19 14:00:49 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 14:38:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/45b10228abfdc23587bd1cd44eb5c1edc39...

Powered by Google App Engine
This is Rietveld 408576698