Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2627033002:
[profiler] Query retainer infos from embedder instead of using object grouping (Closed)
|
Created:
3 years, 11 months ago by Michael Lippautz Modified:
3 years, 11 months ago CC:
Marcel Hlopko, v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[profiler] Query retainer infos from embedder instead of using object grouping
BUG=chromium:679724
Review-Url: https://codereview.chromium.org/2627033002
Cr-Commit-Position: refs/heads/master@{#42628}
Committed: https://chromium.googlesource.com/v8/v8/+/4894bbd4399aeabc994a4e2579809d32ea8b4c29
Patch Set 1 #Patch Set 2 : Make RetainerChildren std::unoredered_set instead of std::vector #Patch Set 3 : Remove test that checks for implicit references as this simply doesn't exist anymore #Patch Set 4 : Replacing implicit ref groups by reriving edges from the embedder #Patch Set 5 : Rebase #Patch Set 6 : Fix compilation #Patch Set 7 : Move out filling edges #Patch Set 8 : Separate CL for API changes. Fix merge artifacts #Patch Set 9 : Rebase and fixes #
Messages
Total messages: 56 (49 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [profiler] Query retainer infos from embedder instead of using object grouping BUG= ========== to ========== [profiler] Query retainer infos from embedder instead of using object grouping BUG=679724 ==========
mlippautz@chromium.org changed reviewers: + alph@chromium.org, haraken@chromium.org, jochen@chromium.org
ptal Chromium side: https://codereview.chromium.org/2625093002/ Basically, instead of going through object grouping, we query *all* RetainedObjectInfo_s from the embedder at once for the snapshot.
lgtm
lgtm
LGTM
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take another look. This is now also handling the functionality implicit reference groups provided. Basically, in the new world, the embedder provides the profiler with the groups (which are purely logical and just for better visualization) and the edges. The implementation in https://codereview.chromium.org/2625093002/ already provides the full graph with edges between DOM nodes but also passes a group (DOM tree) containing all its DOM nodes.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19119) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #7 (id:140001) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #7 (id:150007) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #9 (id:210001) has been deleted
Patchset #8 (id:190001) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [profiler] Query retainer infos from embedder instead of using object grouping BUG=679724 ========== to ========== [profiler] Query retainer infos from embedder instead of using object grouping BUG=chromium:679724 ==========
Patchset #9 (id:250001) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #10 (id:290001) has been deleted
Patchset #9 (id:270001) has been deleted
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, jochen@chromium.org, alph@chromium.org Link to the patchset: https://codereview.chromium.org/2627033002/#ps310001 (title: "Rebase and fixes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 310001, "attempt_start_ts": 1485262148097240,
"parent_rev": "db1de41a62dc90dd853e0e73d941d72fae4ca8f1", "commit_rev":
"4894bbd4399aeabc994a4e2579809d32ea8b4c29"}
Message was sent while issue was closed.
Description was changed from ========== [profiler] Query retainer infos from embedder instead of using object grouping BUG=chromium:679724 ========== to ========== [profiler] Query retainer infos from embedder instead of using object grouping BUG=chromium:679724 Review-Url: https://codereview.chromium.org/2627033002 Cr-Commit-Position: refs/heads/master@{#42628} Committed: https://chromium.googlesource.com/v8/v8/+/4894bbd4399aeabc994a4e2579809d32ea8... ==========
Message was sent while issue was closed.
Committed patchset #9 (id:310001) as https://chromium.googlesource.com/v8/v8/+/4894bbd4399aeabc994a4e2579809d32ea8... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
