[ast] Ensure that AST rewriting for non-top-level can be off-thread

[ast] Ensure that AST rewriting for non-top-level can be off-thread

Adds checks to ensure that AST rewriting only runs for top-level (or eval)
code, that for these cases it runs on the main thread, and that for
non-top-level code it can safely be called off-thread.

BUG=v8:5832
Review-Url: https://codereview.chromium.org/2630563002
Cr-Commit-Position: refs/heads/master@{#42367}
Committed: https://chromium.googlesource.com/v8/v8/+/064c584a11326051fbe1d02e3dfd1ec33cbd609e

[Leszek Swirski, 2017-01-12 15:46:37]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 15:46:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 15:49:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:49:56]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19015)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15444)

[Leszek Swirski, 2017-01-12 15:52:29]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 15:52:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 16:27:46]

Dry run: This issue passed the CQ dry run.

[Leszek Swirski, 2017-01-13 16:10:41]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 16:10:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek Swirski, 2017-01-13 16:14:06]

leszeks@chromium.org changed reviewers:
+ marja@chromium.org

[Leszek Swirski, 2017-01-13 16:14:06]

Hi Marja,

What do you think of these additional checks, as part of our "offthread compile"
initiative?

[commit-bot: I haz the power, 2017-01-13 16:53:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 16:53:58]

Dry run: This issue passed the CQ dry run.

[marja, 2017-01-16 10:21:29]

lgtm

[Leszek Swirski, 2017-01-16 11:29:50]

The CQ bit was checked by leszeks@chromium.org

[commit-bot: I haz the power, 2017-01-16 11:29:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 12:03:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484566190186530,
"parent_rev": "8f0bf07b504e8bb27ef3703388c4c0699670331f", "commit_rev":
"064c584a11326051fbe1d02e3dfd1ec33cbd609e"}

[commit-bot: I haz the power, 2017-01-16 12:03:18]

Description was changed from

==========
[ast] Ensure that AST rewriting for non-top-level can be off-thread

Adds checks to ensure that AST rewriting only runs for top-level (or eval)
code, that for these cases it runs on the main thread, and that for
non-top-level code it can safely be called off-thread.

BUG=v8:5832
==========

to

==========
[ast] Ensure that AST rewriting for non-top-level can be off-thread

Adds checks to ensure that AST rewriting only runs for top-level (or eval)
code, that for these cases it runs on the main thread, and that for
non-top-level code it can safely be called off-thread.

BUG=v8:5832

Review-Url: https://codereview.chromium.org/2630563002
Cr-Commit-Position: refs/heads/master@{#42367}
Committed:
https://chromium.googlesource.com/v8/v8/+/064c584a11326051fbe1d02e3dfd1ec33cb...
==========

[commit-bot: I haz the power, 2017-01-16 12:03:19]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/064c584a11326051fbe1d02e3dfd1ec33cb...