[ignition] Create the type feedback vector after bytecode generation

[ignition] Create the type feedback vector after bytecode generation

BUG=v8:5832
Review-Url: https://codereview.chromium.org/2627783008
Cr-Commit-Position: refs/heads/master@{#42377}
Committed: https://chromium.googlesource.com/v8/v8/+/d4ac63de7c75e25d44880d15d604473f9dfa8049

[Leszek Swirski, 2017-01-12 17:33:13]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 17:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 18:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:05:07]

Dry run: This issue passed the CQ dry run.

[Leszek Swirski, 2017-01-13 16:32:27]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 16:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek Swirski, 2017-01-13 16:40:28]

leszeks@chromium.org changed reviewers:
+ mvstanton@chromium.org, rmcilroy@chromium.org

[Leszek Swirski, 2017-01-13 16:40:28]

Hi Ross and Mike,

What do you think of these changes to type feedback metadata allocation, where
on the "normal" ignition path the allocation is deferred until after the
bytecode generation?

[commit-bot: I haz the power, 2017-01-13 17:17:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 17:17:56]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2017-01-16 10:51:16]

LGTM.

[Leszek Swirski, 2017-01-16 12:03:54]

The CQ bit was checked by leszeks@chromium.org

[commit-bot: I haz the power, 2017-01-16 12:03:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek Swirski, 2017-01-16 13:33:34]

The CQ bit was unchecked by leszeks@chromium.org

[Leszek Swirski, 2017-01-16 13:33:34]

The CQ bit was checked by leszeks@chromium.org

[commit-bot: I haz the power, 2017-01-16 13:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 14:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 14:04:25]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)

[Leszek Swirski, 2017-01-16 14:05:09]

The CQ bit was checked by leszeks@chromium.org

[commit-bot: I haz the power, 2017-01-16 14:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 14:29:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484575509731190,
"parent_rev": "ac45f88acb2da1e6dad4e4afe08fd7afcccd571d", "commit_rev":
"d4ac63de7c75e25d44880d15d604473f9dfa8049"}

[commit-bot: I haz the power, 2017-01-16 14:29:13]

Description was changed from

==========
[ignition] Create the type feedback vector after bytecode generation

BUG=v8:5832
==========

to

==========
[ignition] Create the type feedback vector after bytecode generation

BUG=v8:5832

Review-Url: https://codereview.chromium.org/2627783008
Cr-Commit-Position: refs/heads/master@{#42377}
Committed:
https://chromium.googlesource.com/v8/v8/+/d4ac63de7c75e25d44880d15d604473f9df...
==========

[commit-bot: I haz the power, 2017-01-16 14:29:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d4ac63de7c75e25d44880d15d604473f9df...

[Michael Starzinger, 2017-01-16 15:28:40]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2017-01-16 15:28:41]

https://codereview.chromium.org/2627783008/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2627783008/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:659:
TypeFeedbackMetadata::EnsureAllocated(
Some follow-up questions:
1) Would it be possible to do this in FinalizeUnoptimizedCompilationJob instead?
2) And more importantly could we keep it in sync with FCG and also allocate it
just before unoptimized code is installed for FullCodegenCompilationJob?

[Leszek Swirski, 2017-01-16 16:28:03]

https://codereview.chromium.org/2627783008/diff/20001/src/interpreter/bytecod...
File src/interpreter/bytecode-generator.cc (right):

https://codereview.chromium.org/2627783008/diff/20001/src/interpreter/bytecod...
src/interpreter/bytecode-generator.cc:659:
TypeFeedbackMetadata::EnsureAllocated(
On 2017/01/16 15:28:41, Michael Starzinger wrote:
> Some follow-up questions:
> 1) Would it be possible to do this in FinalizeUnoptimizedCompilationJob
instead?
> 2) And more importantly could we keep it in sync with FCG and also allocate it
> just before unoptimized code is installed for FullCodegenCompilationJob?

I'm hesitant, could this interact badly with --always-opt?