Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2630383002: [Autofill] Increase padding for multiline labels in dropdown (Closed)

Created:
3 years, 11 months ago by Mathieu
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Increase padding for multiline labels in dropdown For multiline labels, the dropdown wrapper view height was set to WRAP_CONTENT instead of a fixed height. However this leaves no padding on the text view. BUG=681593 TEST=manual Review-Url: https://codereview.chromium.org/2630383002 Cr-Commit-Position: refs/heads/master@{#444086} Committed: https://chromium.googlesource.com/chromium/src/+/3fe3d39e93d6f7b4ba011074fc322fecb713d3f6

Patch Set 1 : Initial #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M ui/android/java/src/org/chromium/ui/DropdownAdapter.java View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Mathieu
Hi Ted, PTAL
3 years, 11 months ago (2017-01-16 16:49:27 UTC) #4
Ted C
lgtm
3 years, 11 months ago (2017-01-17 16:45:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630383002/20001
3 years, 11 months ago (2017-01-17 17:07:31 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 17:50:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3fe3d39e93d6f7b4ba011074fc32...

Powered by Google App Engine
This is Rietveld 408576698