Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Unified Diff: ui/android/java/src/org/chromium/ui/DropdownAdapter.java

Issue 2630383002: [Autofill] Increase padding for multiline labels in dropdown (Closed)
Patch Set: Initial Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/DropdownAdapter.java
diff --git a/ui/android/java/src/org/chromium/ui/DropdownAdapter.java b/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
index ce74633ee7f54225aa6b82436ec8f04c7dd1930a..3f502c6ca627b5b89be3d59252ed51d5859de4f0 100644
--- a/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
+++ b/ui/android/java/src/org/chromium/ui/DropdownAdapter.java
@@ -141,6 +141,14 @@ public class DropdownAdapter extends ArrayAdapter<DropdownItem> {
ApiCompatibilityUtils.setMarginStart(layoutParams, labelMargin);
ApiCompatibilityUtils.setMarginEnd(layoutParams, labelMargin);
labelView.setLayoutParams(layoutParams);
+ if (item.isMultilineLabel()) {
+ // If there is a multiline label, we add extra padding top and bottom because
+ // WRAP_CONTENT, defined above for multiline labels, leaves none.
+ int existingStart = ApiCompatibilityUtils.getPaddingStart(labelView);
+ int existingEnd = ApiCompatibilityUtils.getPaddingEnd(labelView);
+ ApiCompatibilityUtils.setPaddingRelative(
+ labelView, existingStart, labelMargin, existingEnd, labelMargin);
+ }
}
labelView.setEnabled(item.isEnabled());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698