Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2629943002: Ensures that the gold output directory exists (Closed)

Created:
3 years, 11 months ago by stephana
Modified:
3 years, 11 months ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Ensures that the gold output directory exists This will land after this CL https://chromium-review.googlesource.com/c/424575/ as a way of making sure it works as intended. TBR=borenet BUG=skia:5973 Review-Url: https://codereview.chromium.org/2629943002 Committed: https://pdfium.googlesource.com/pdfium/+/38c2705c697cd9a67b02ead1d601610d7af96524

Patch Set 1 #

Patch Set 2 : Fixed bug for failing pdfium_test runs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M testing/tools/gold.py View 1 chunk +4 lines, -0 lines 0 comments Download
M testing/tools/test_runner.py View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
stephana
This is a small fix to gold related code for testing. I thought we could ...
3 years, 11 months ago (2017-01-13 17:56:49 UTC) #3
Wei Li
lgtm
3 years, 11 months ago (2017-01-13 18:56:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629943002/1
3 years, 11 months ago (2017-01-13 18:56:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/builds/3372) mac_xfa_rel on master.tryserver.client.pdfium (JOB_FAILED, ...
3 years, 11 months ago (2017-01-13 18:58:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629943002/1
3 years, 11 months ago (2017-01-13 20:22:15 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_xfa on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/3376)
3 years, 11 months ago (2017-01-13 20:28:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629943002/20001
3 years, 11 months ago (2017-01-13 20:52:30 UTC) #17
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-13 21:06:17 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 21:16:46 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/38c2705c697cd9a67b02ead1d601610d7af9...

Powered by Google App Engine
This is Rietveld 408576698