Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: testing/tools/test_runner.py

Issue 2629943002: Ensures that the gold output directory exists (Closed)
Patch Set: Fixed bug for failing pdfium_test runs Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/tools/gold.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/tools/test_runner.py
diff --git a/testing/tools/test_runner.py b/testing/tools/test_runner.py
index fad7a9c66a04437c1b93fe0581eed33635fc6250..92db9118dd689317d987016f887c8865956ce385 100644
--- a/testing/tools/test_runner.py
+++ b/testing/tools/test_runner.py
@@ -127,10 +127,11 @@ class TestRunner:
def HandleResult(self, input_filename, input_path, result):
if self.gold_results:
success, image_paths = result
- for img_path, md5_hash in image_paths:
- # the output filename (without extension becomes the test name)
- test_name = os.path.splitext(os.path.split(img_path)[1])[0]
- self.gold_results.AddTestResult(test_name, md5_hash, img_path)
+ if image_paths:
+ for img_path, md5_hash in image_paths:
+ # the output filename (without extension becomes the test name)
+ test_name = os.path.splitext(os.path.split(img_path)[1])[0]
+ self.gold_results.AddTestResult(test_name, md5_hash, img_path)
if self.test_suppressor.IsResultSuppressed(input_filename):
if result:
« no previous file with comments | « testing/tools/gold.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698