Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2629733002: Create suffix to run more than one flaky EarlGrey target. (Closed)

Created:
3 years, 11 months ago by baxley
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create suffix to run more than one flaky EarlGrey target. Allow there to be multiple suites that run on the flaky bot, since we have more than one test suite. Use the appendix "_flaky_egtests" to denote targets. Previously it only ran "ios_chrome_flaky_egtests". BUG=675613 Review-Url: https://codereview.chromium.org/2629733002 Cr-Commit-Position: refs/heads/master@{#443468} Committed: https://chromium.googlesource.com/chromium/src/+/b457f0ab9dac0e67cab0b84134999a1c6b0d5e40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ios/chrome/test/earl_grey/chrome_test_case.mm View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
baxley
This should allow us to run multiple Chrome flaky test suites. More work will be ...
3 years, 11 months ago (2017-01-12 23:18:42 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 11 months ago (2017-01-12 23:20:05 UTC) #3
huangml1
lgtm
3 years, 11 months ago (2017-01-12 23:23:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629733002/1
3 years, 11 months ago (2017-01-12 23:24:57 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:20:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b457f0ab9dac0e67cab0b8413499...

Powered by Google App Engine
This is Rietveld 408576698